Skip to content

Import the most recent test_suite from google/jsonnet #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

stephenamar-db
Copy link
Collaborator

@stephenamar-db stephenamar-db commented May 15, 2025

Pretty large PR.
This imports all of non-lint test_suites from google/jsonnet and:

  • Regenerate each golden file with the script
  • Change ErrorTests to automatically pick the files up and test them.

Still need to do FileTests, but it already picked up a lot of small bugs that we'll have to fix like:

  • Formatting issues with number with exponents
  • Bad rounding with the number 0
    ....

@stephenamar-db
Copy link
Collaborator Author

Sadly, I have to have big test() and then loop through each case.
Would love for com-lihaoyi/utest#367 to be addressed.

@stephenamar-db
Copy link
Collaborator Author

@He-Pin

@stephenamar-db stephenamar-db merged commit ad8045f into master May 15, 2025
6 checks passed
@He-Pin
Copy link
Contributor

He-Pin commented May 15, 2025

There are some additional tests live in google/go-jsonnet , has that been included too?

@stephenamar-db
Copy link
Collaborator Author

that's a lot more to add. let's deal with the discrepancies found in the c++ test suite first, and we'll import the go-jsonnet test suite later.

@stephenamar-db stephenamar-db deleted the stephenamar-db/stack/files branch May 15, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants