-
-
Notifications
You must be signed in to change notification settings - Fork 153
API: Add keyword for match_node_purpose #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add keyword for match_node_purpose #164
Conversation
Looks like this has some merge conflicts after the big refactor in #162. @TomAugspurger are you ok to resolve those? Sorry! |
I think updating or merging this would be helpful (see pangeo-data/pangeo-cloud-federation#567). @TomAugspurger can you give an example of how users can select this setting in dask_cofig.yaml or elsewhere? For example in JupyterHub values.yaml we can set:
|
Hopefully got the rebase correct. Haven't run the tests or anything locally
though.
…On Thu, Mar 19, 2020 at 11:24 AM Scott Henderson ***@***.***> wrote:
I think updating or merging this would be helpful (see
pangeo-data/pangeo-cloud-federation#567
<pangeo-data/pangeo-cloud-federation#567>).
@TomAugspurger <https://github.com/TomAugspurger> can you give an example
of how users can select this setting in dask_cofig.yaml or elsewhere?
For example in JupyterHub values.yaml we can set:
jupyterhub:
scheduling:
userPods:
nodeAffinity:
matchNodePurpose: prefer
corePods:
nodeAffinity:
matchNodePurpose: require
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIRZTKWPACCFOTDBP3LRIJBKVANCNFSM4IEBMRTA>
.
|
Thanks @TomAugspurger. Not sure what worked as CI is failing. |
Thanks @TomAugspurger. CI seems to be failing now. Could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like clean_pod_spec
is not a valid fixture?
@@ -7,6 +7,7 @@ kubernetes: | |||
host: "0.0.0.0" | |||
port: 0 | |||
env: {} | |||
match_node_purpose: "prefer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better as match-node-purpose
I am going to close this out as it is rather old and I think the Pangeo folks have moved to `dask-gateway anyway. Sorry this got dropped. Feel free to ping here if it still has value. |
Closes pangeo-data/pangeo-stacks#59