Skip to content

Removed verbose printing on DevTools events, test webdev with local dwds #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
- Add an `ide` query parameter to the Dart DevTools URL for analytics.
- Fix a race where injected client crashed on events send just before hot
restart.
- Remove verbose printing on receiving DevTools events.
- Update `vm_service` version to `^8.2.0`.


**Breaking changes:**
- `Dwds.start` and `ExpressionCompilerService` now take
Expand Down
20 changes: 13 additions & 7 deletions dwds/lib/src/dwds_vm_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -150,25 +150,31 @@ void _processSendEvent(Map<String, dynamic> event,
switch (type) {
case 'DevtoolsEvent':
{
_logger.finest('Received DevTools event: $event');
var action = payload == null ? null : payload['action'];
if (action == 'pageReady') {
if (dwdsStats.isFirstDebuggerReady) {
if (dwdsStats.devToolsStart != null) {
emitEvent(DwdsEvent.devToolsLoad(DateTime.now()
var time = DateTime.now()
.difference(dwdsStats.devToolsStart)
.inMilliseconds));
.inMilliseconds;
emitEvent(DwdsEvent.devToolsLoad(time));
_logger.fine('DevTools load time: $time ms');
}
if (dwdsStats.debuggerStart != null) {
emitEvent(DwdsEvent.debuggerReady(DateTime.now()
var time = DateTime.now()
.difference(dwdsStats.debuggerStart)
.inMilliseconds));
.inMilliseconds;
emitEvent(DwdsEvent.debuggerReady(time));
_logger.fine('Debugger ready time: $time ms');
}
} else {
print('Ignoring already received event: $event');
_logger.warning('Ignoring already received event: $event');
_logger
.finest('Debugger and DevTools startup times alredy recorded.'
' Ignoring $event.');
}
} else {
_logger.warning('Ignoring unknown event: $event');
_logger.finest('Ignoring unknown event: $event');
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/injected/client.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies:
stack_trace: ^1.10.0
sse: ^4.1.0
uuid: '>=2.0.0 <4.0.0'
vm_service: ^8.1.0
vm_service: ^8.2.0
web_socket_channel: ^2.0.0
webkit_inspection_protocol: ^1.0.0

Expand Down
2 changes: 1 addition & 1 deletion webdev/lib/src/serve/webdev_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class WebDevServer {
options.configuration.hostname,
options.port,
assetHandler,
options.configuration.verbose,
verbose: options.configuration.verbose,
);
}
var shouldServeDevTools =
Expand Down
2 changes: 1 addition & 1 deletion webdev/lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions webdev/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: webdev
# Every time this changes you need to run `dart run build_runner build`.
version: 2.7.8
version: 2.7.9-dev
# We should not depend on a dev SDK before publishing.
# publish_to: none
homepage: https://github.com/dart-lang/webdev
Expand Down Expand Up @@ -47,10 +47,10 @@ dev_dependencies:
test_process: ^2.0.2
webdriver: ^3.0.0

# Uncomment for development versions
# dependency_overrides:
# dwds:
# path: ../dwds
# Comment out before releasing webdev.
dependency_overrides:
dwds:
path: ../dwds

executables:
webdev: