Skip to content

Support embedded debugging experience in environments with nested Dart app ID #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2022
Merged

Support embedded debugging experience in environments with nested Dart app ID #1525

merged 3 commits into from
Feb 28, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 25, 2022 •
edited
Loading

  • Adds support for using the embedded Dart DevTools in Chrome DevTools in environments where the Dart app context (and therefore Dart app ID) is in a nested IFRAME
  • Also renames _handleDevToolsOpen to _handleMessageFromPanelScript for clarity.
  • Makes the "Start debugging" button disabled while the panel is initially loading, and after a user clicks it and the embedded Dart DevTools is loading.

@elliette elliette requested a review from grouma February 25, 2022 22:10
@grouma
Copy link
Member

grouma commented Feb 25, 2022

  • Adds support for using the embedded Dart DevTools in Chrome DevTools in environments where we have no Dart app ID (eg, Bolt).

We do have a Dart app ID in this case, however it's just in a different execution context due to nesting of iFrames.

@elliette
Copy link
Contributor Author

We do have a Dart app ID in this case, however it's just in a different execution context due to nesting of iFrames.

Oh excellent! Modified this to get the Dart app ID from the nested IFRAMEs. Thanks!

@elliette elliette changed the title Support embedded debugging experience in environments with no Dart app ID Support embedded debugging experience in environments with nested Dart app ID Feb 28, 2022
@elliette elliette merged commit 9cfdbdd into dart-lang:master Feb 28, 2022
@elliette elliette deleted the support-tests branch May 4, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grouma grouma grouma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @grouma