Add metrics for devtools IPL #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Sep 8, 2021
nshahan
reviewed
Sep 8, 2021
grouma
approved these changes
Sep 8, 2021
|
Tests are failing due to the new stable SDK release, as intended. Will be fixed by #1405 |
nshahan
approved these changes
Sep 8, 2021
natebosch
reviewed
Sep 8, 2021
annagrin
force-pushed
the
annagrin/add_ipl_metrics
branch
from
627dee5 to
922baf6
Compare
|
Addressed the CR comments and removed reporting metrics for |
natebosch
approved these changes
Sep 8, 2021
|
@grouma @natebosch I changed how events are created to concentrate all the constants in one place - appreciate another review. |
annagrin
commented
Sep 9, 2021
natebosch
approved these changes
Sep 9, 2021
natebosch
approved these changes
Sep 9, 2021
added 8 commits
September 9, 2021 15:51
annagrin
force-pushed
the
annagrin/add_ipl_metrics
branch
from
fa02c57 to
8e5e88d
Compare
natebosch
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics to track DevTools IPL and VM calls on the critical path to loading DevTools app.
In addition, differentiate between errors returning
ErrorRefand exceptions fromevaluateandevaluateInFramecalls.This change needs flutter/devtools#3346 to actually send events for devtools IPL, will be a noop with earlier devtools verssions.
Closes: #1403