Skip to content

Deprecate a few more things before we launch v2 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Deprecate a few more things before we launch v2 #348

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9f13c
Deprecate a few more things before we launch v2
kevmoo Feb 26, 2025
21dc2ec
deprecate one more thing
kevmoo Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/lib/src/helpers/extensions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ extension HTMLCanvasElementGlue on HTMLCanvasElement {
}

extension CanvasRenderingContext2DGlue on CanvasRenderingContext2D {
@Deprecated('See CanvasRenderingContext2D.drawImage')
void drawImageScaled(
CanvasImageSource image,
double dx,
Expand Down Expand Up @@ -122,9 +123,8 @@ extension XMLHttpRequestGlue on XMLHttpRequest {
// from Closure's goog.net.Xhrio.getResponseHeaders.
final headers = <String, String>{};
final headersString = getAllResponseHeaders();
final headersList =
LineSplitter.split(headersString).where((header) => header.isNotEmpty);
for (final header in headersList) {
for (final header in LineSplitter.split(headersString)
.where((header) => header.isNotEmpty)) {
final split = header.split(': ');
if (split.length <= 1) {
continue;
Expand Down
Loading