-
Notifications
You must be signed in to change notification settings - Fork 220
Add --coverage-lcov
and --branch-coverage
options
#2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liamappelbe
wants to merge
15
commits into
master
Choose a base branch
from
coverage_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
This comment was marked as resolved.
This comment was marked as resolved.
--coverage-lcov
and --branch-cov
options--coverage-lcov
and --branch-cov
options
--coverage-lcov
and --branch-cov
options--coverage-lcov
and --branch-coverage
options
The remaining test failures don't seem related to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--coverage-lcov
option todart test
, which takes a filename. This option works like--coverage
, except that instead of generating multiple JSON reports, it generates a single LCOV report.pkgs/test_core/lib/src/runner/coverage.dart
's coverage collection functions, and howpkgs/test_core/lib/src/runner/engine.dart
invokes them.writeCoverage
is still called, but doesn't write the JSON file. Instead it returns the generated coverage report. TheEngine
merges all these coverage reports into_allCoverageData
, and once all the tests are done it callswriteCoverageLcov
to finalize the report and write it to the lcov file.--branch-coverage
flag that is plumbed through tocollect
'sbranchCoverage
param.--coverage-lcov
workflow.collect
'sscopedOutput
param to the current package name. This front load the filtering of the coverage report, improving performance by removing unnecessary information as early as possible.runPub
was using the deprecated standalonepub
tool. This didn't cause problems because it was dead code. But I had to use it in the new tests, so I updated it to usedart pub
.Fixes #2511