feat!: allow analyzer 7.0.0 and update dart_style to ^3.0.0

[Peetee06]

Allows analyzer version ^7.0.0 and update dart_style to ^3.0.0.

The update of dart_style to ^3.0.0 is a breaking change.

Related issue: #950

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
intl_translation	Breaking	0.20.1	0.21.0-wip	0.21.0	✔️

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

File	Coverage
pkgs/intl_translation/lib/src/messages/constant_evaluator.dart	💚 41 %
pkgs/intl_translation/lib/src/messages/main_message.dart	💚 56 %
pkgs/intl_translation/lib/src/messages/message.dart	💚 86 % ⬆️ 0 %
pkgs/intl_translation/lib/visitors/message_finding_visitor.dart	💚 84 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols
intl_translation	Message MainMessage

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

[Peetee06]

Had to also update dart_style to ^3.0.0 to support analyzer ^7.0.0. See dart_style changelogs

That should also fix this failing check

[mosuem]

Are these necessary?

[Peetee06]

I'm unsure about all the implications of removing this.

From the dart_style changelog I understand that this will override the language version that the DartFormatter would use. Meaning it will always format based on Dart 2.12, instead of the users' language version.

They are added via this file that I didn't touch.

I used the regenerate.sh scripts here and here to apply the updated formatting.

[Peetee06]

@mosuem

One of the workflows fail:

info - lib/src/messages/message.dart:78:29 - 'ConstantEvaluator' is deprecated and shouldn't be used. This has no uses in package:analyzer and not exhaustive. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use

It seems ConstantEvaluator was deprecated in analyzer 7.x.x.

I don't know what the replacement for that is and currently don't have the capacity to dive into this deeper.

Would you be okay with me adding an ignore and TODO comment, so this can be addressed once the analyzer dependency constraints are updated to a version where this is fully removed?

[mosuem]

I looked up who would do such a stupid thing as deprecating without giving an alternative - it was me! 😆

I do think that replacing it would be the safer choice, this library is brittle enough as is...

Maybe something along the lines of what I did in that PR could also be done here?

bool _isConst(Expression expression) {
    if (expression.inConstantContext) {
      return true;
    } else if (expression is InstanceCreationExpression && expression.isConst) {
      return true;
    } else if (expression is Literal) {
      return switch (expression) {
        BooleanLiteral() => true,
        DoubleLiteral() => true,
        IntegerLiteral() => true,
        NullLiteral() => true,
        SimpleStringLiteral() => true,
        AdjacentStrings() => true,
        SymbolLiteral() => true,
        RecordLiteral() => expression.isConst,
        TypedLiteral() => expression.isConst,
        // TODO(mosum): Expand the logic to check if the individual interpolation elements are const.
        StringInterpolation() => false,
      };
    } else if (expression is Identifier) {
      var staticElement = expression.staticElement;
      if (staticElement != null) {
        if ((staticElement is VariableElement && staticElement.isConst) ||
            staticElement.nonSynthetic is ConstVariableElement) {
          return true;
        }
      }
    }
    return false;
  }

Let me check.

[mosuem]

Something like the last commit in this maybe? #972

[Peetee06]

@mosuem do we need the generic T here? I don't see it used anywhere.

[mosuem]

No, that's a refactoring leftover I believe

[Peetee06]

Thank you for the code suggestion and the timely reviews!

I cherry-picked the commit into this PR. All tests are passing locally.

Hopefully the pipeline does, too 🤞

[Peetee06]

@mosuem there is another ConstantEvaluator in lib/visitors/message_finding_visitor.dart which needs to be replaced.

I naiively tried to replace it with evaluateConstString, but a test is still failing. Pretty sure only evaluating const strings isn't enough in this instance.

Could you give some guidance how to replace it there? :)

[mosuem]

I added a fix - probably some tests would be nice to have though.

[Peetee06]

@mosuem thanks for supporting with the fix 👍

I let AI create some test cases. They make sense to me.

Would be great if you could check if they are actually useful and if we should drop or add some cases.