This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Replace Future.wait with Iterable<Future>.wait #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #111
kevmoo
approved these changes
Jun 13, 2024
lrhn
reviewed
Jun 14, 2024
| @@ -138,7 +138,7 @@ extension AggregateSample<T> on Stream<T> { | |||
| // Handle opt-out nulls | |||
| cancels.removeWhere((Object? f) => f == null); | |||
| if (cancels.isEmpty) return null; | |||
| return Future.wait(cancels).then((_) => null); | |||
| return cancels.wait.then((_) => null); | |||
There was a problem hiding this comment.
Could all these (_) => null use the same top-level helper function, void voidCallback(void _) {}?
That should ensure we only have one function instance, instead of one per call point.
lrhn
reviewed
Jun 14, 2024
| @@ -128,7 +128,7 @@ extension SwitchLatest<T> on Stream<Stream<T>> { | |||
| // Handle opt-out nulls | |||
| ..removeWhere((Object? f) => f == null); | |||
| if (cancels.isEmpty) return null; | |||
| return Future.wait(cancels).then(_ignore); | |||
| return cancels.wait.then(_ignore); | |||
There was a problem hiding this comment.
Can be (_) => null like the rest, or use the same helper function.
lrhn
approved these changes
Jun 14, 2024
natebosch
added a commit
that referenced
this pull request
Jun 17, 2024
Add a `common_callbacks.dart` library with a single top level function `ignoreArgument` which takes a single `dynamic` argument and does nothing. Replace all `(_) => null` function literals, as well as a few library-private functions with unnecessarily specific signatures, with the shared definition. As suggested in #188
natebosch
added a commit
that referenced
this pull request
Oct 19, 2024
Add a `common_callbacks.dart` library with a single top level function `ignoreArgument` which takes a single `dynamic` argument and does nothing. Replace all `(_) => null` function literals, as well as a few library-private functions with unnecessarily specific signatures, with the shared definition. As suggested in #188
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
…ransform#188) Towards dart-lang/stream_transform#111
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
Add a `common_callbacks.dart` library with a single top level function `ignoreArgument` which takes a single `dynamic` argument and does nothing. Replace all `(_) => null` function literals, as well as a few library-private functions with unnecessarily specific signatures, with the shared definition. As suggested in dart-archive/stream_transform#188
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards dart-lang/tools#1771