Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

fix: Pubspec.environment can never be null #137

Merged

Conversation

spydon
Copy link
Contributor

@spydon spydon commented Oct 27, 2024

Since Pubspec.environment defaults to an empty map in the initializer list it can never be null.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@spydon
Copy link
Contributor Author

spydon commented Nov 19, 2024

@kevmoo could you have a look at this oneliner? 🙏

@kevmoo
Copy link
Contributor

kevmoo commented Nov 19, 2024

Let's see what the CI says, @spydon 😀

@spydon
Copy link
Contributor Author

spydon commented Nov 19, 2024

Let's see what the CI says, @spydon 😀

I removed the deprecated rule here: #141

@kevmoo
Copy link
Contributor

kevmoo commented Nov 19, 2024

thanks for fixing the rule.
Please update the changelog

@spydon
Copy link
Contributor Author

spydon commented Nov 19, 2024

thanks for fixing the rule. Please update the changelog

Done! I'm so used to that the changelog is generated from the conventional commits. 😜

@kevmoo
Copy link
Contributor

kevmoo commented Nov 19, 2024

you'll need to run dart run build_runner build

@devoncarew devoncarew merged commit 74c350c into dart-archive:master Dec 10, 2024
6 checks passed
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 20, 2024
…e#137)

* fix: Pubspec.environment can never be null

* chore: Add changelog entry

* fix: _environmentMap to return empty map when input is null
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants