This repository was archived by the owner on Oct 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the min SDK to 2.10.0-0 to get a language version of `2.10`. Move dependency overrides to the master branches for the packages which support the 2.10 SDK on the master branch. Update travis config to run with `--enable-experiment=non-nullable` and test on the `null_safety` branch. Use the pattern from `package:collection`. Delete some migration comments that are left over.
This looks like it was already partially merged to me? Not sure what is going on exactly here. |
Yup. I had a null safe branch locally. I can rebase if you like. |
I am mostly confused by the pull request description which doesn't seem accurate? |
PTAL |
@jakemac53 – should I just prepare this for publish? |
cc @natebosch do you have anything you want to do on this package before we release it? |
jakemac53
approved these changes
Nov 5, 2020
It looks like we need to bump the major version. |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
Update dependencies and travis config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies and travis config