Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

Update SDK constraint to 2.12.0-0 #38

Merged
merged 9 commits into from
Nov 5, 2020
Merged

Update SDK constraint to 2.12.0-0 #38

merged 9 commits into from
Nov 5, 2020

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Nov 5, 2020

Update dependencies and travis config

stereotype441 and others added 8 commits April 7, 2020 20:55
Set the min SDK to 2.10.0-0 to get a language version of `2.10`.

Move dependency overrides to the master branches for the packages which
support the 2.10 SDK on the master branch.

Update travis config to run with `--enable-experiment=non-nullable` and
test on the `null_safety` branch. Use the pattern from `package:collection`.

Delete some migration comments that are left over.
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@kevmoo kevmoo requested review from natebosch and jakemac53 November 5, 2020 21:32
@jakemac53
Copy link
Contributor

This looks like it was already partially merged to me? Not sure what is going on exactly here.

@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 5, 2020

This looks like it was already partially merged to me? Not sure what is going on exactly here.

Yup. I had a null safe branch locally. I can rebase if you like.

@jakemac53
Copy link
Contributor

jakemac53 commented Nov 5, 2020

I am mostly confused by the pull request description which doesn't seem accurate?

@kevmoo kevmoo changed the title null safety Update SDK constraint to 2.12.0-0 Nov 5, 2020
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 5, 2020

PTAL

@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 5, 2020

@jakemac53 – should I just prepare this for publish?

@jakemac53
Copy link
Contributor

cc @natebosch do you have anything you want to do on this package before we release it?

@kevmoo kevmoo merged commit 9d6ebbe into master Nov 5, 2020
@kevmoo kevmoo deleted the null_safety branch November 5, 2020 23:31
@natebosch
Copy link
Contributor

It looks like we need to bump the major version.

mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants