Skip to content

Panasonic v8 #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 13, 2025
Merged

Panasonic v8 #839

merged 24 commits into from
May 13, 2025

Conversation

LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented May 13, 2025

Baseline perf numbers:

raw.pixls.us$ ~/rawspeed/build-Clang20-Release/src/utilities/rsbench/rsbench Panasonic/DC-S5M2/P1126458_mechanical.RW2 --benchmark_min_warmup_time=0.5 --benchmark_min_time=0s --benchmark_repetitions=49 --benchmark_counters_tabular=true -t --benchmark_filter="/threads:(1|32)/" --benchmark_display_aggregates_only=true
2025-05-13T23:05:50+03:00
Running /home/lebedevri/rawspeed/build-Clang20-Release/src/utilities/rsbench/rsbench
Run on (32 X 3400 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x16)
  L1 Instruction 32 KiB (x16)
  L2 Unified 512 KiB (x16)
  L3 Unified 32768 KiB (x2)
Load Average: 2.11, 1.41, 1.92
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Benchmark                                                                                   Time             CPU   Iterations  CPUTime,s CPUTime/WallTime     Pixels Pixels/CPUTime Pixels/WallTime Raws/CPUTime Raws/WallTime WallTime,s
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:1/process_time/real_time_mean           324 ms          323 ms           49   0.323491         0.999827   24.0801M       74.4381M        74.4253M      3.09128       3.09074   0.323547
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:1/process_time/real_time_median         323 ms          323 ms           49   0.323431         0.999878   24.0801M       74.4519M        74.4376M      3.09185       3.09125   0.323493
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:1/process_time/real_time_stddev       0.292 ms        0.295 ms           49   295.447u         164.387u   0.357217       67.8351k        66.9846k     2.81706m      2.78174m    291.81u
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:1/process_time/real_time_cv            0.09 %          0.09 %            49      0.09%            0.02%      0.00%          0.09%           0.09%        0.09%         0.09%      0.09%
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:32/process_time/real_time_mean          170 ms          339 ms           49   0.339483          1.99981   24.0801M       70.9316M         141.85M      2.94566       5.89076   0.169757
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:32/process_time/real_time_median        170 ms          339 ms           49   0.339501          1.99987   24.0801M       70.9278M        141.846M       2.9455       5.89061   0.169762
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:32/process_time/real_time_stddev      0.134 ms        0.269 ms           49   269.129u         227.159u   0.357217       56.2403k        111.832k     2.33556m      4.64419m   133.816u
Panasonic/DC-S5M2/P1126458_mechanical.RW2/threads:32/process_time/real_time_cv           0.08 %          0.08 %            49      0.08%            0.01%      0.00%          0.08%           0.08%        0.08%         0.08%      0.08%

kmilos and others added 23 commits February 22, 2024 15:47
Adapted from the Rust implementation in @cytrinox [dnglab](https://github.com/dnglab/dnglab). Should make it possible to provide support for several newer Panasonic cameras: G9M2, S5II, S1RII, GH6, GH7, and S9.

In this branch, cameras.xml has only been updated for the G9M2.
I had missed these because I have been building the library through Darktable.
* upstream/develop:
  .. but that directory isn't actually empty, it just doesn't have files
  CI: skip step if no clang-tidy YAML reports
  CI: run CodeQL static analysis even if some steps failed
  CI: disable `-Werror` for static analysis jobs
  Github: sarif-ify clang-tidy output
  CMake: add `RAWSPEED_ENABLE_CLANG_TIDY_WERROR` option
  Explicitly opt-out of `alpha.unix.Stream` CSA check
  rstest: add (some) missing checks that writing succeeded
  `FileReader::readFile()`: first check for erorr, then eof
  Upload CodeChecker results as SARIF
  Switch RPU masterset fetching to wget
  Add Nikon Z5_2 placeholder
* upstream/develop: (53 commits)
  CI: make clang-format check more user-friendly
  Re-apply clang-format
  `.clang-format-ignore`: some of the patterns should specify `^`/`$` to avoid spuriously ignored files
  Github actions: create `/etc/apt/sources.list.d` if it does not exist
  Revert "Github actions: don't create `/etc/apt/sources.list.d`, it already exists"
  clang-tidy: `readability-braces-around-statements`
  clang-tidy: `performance-unnecessary-copy-initialization`
  clang-tidy: apply `readability-use-std-min-max`
  clang-tidy: `modernize-min-max-use-initializer-list`
  clang-tidy: apply `misc-include-cleaner`
  Apply clang-tidy's `misc-use-internal-linkage` to tests
  rstest: apply `misc-use-internal-linkage`
  identify: apply `misc-use-internal-linkage`
  SamsungV2Decompressor: apply `misc-use-internal-linkage`
  clang-tidy: auto-fix `readability-math-missing-parentheses`
  CI: some more compiler version rollsa
  CI: bump timeout on macos job
  CI: osx
  Remove uncompressed mode from more Nikon models
  Remove uncompressed mode from Nikon entry level DSLRs
  ...
* upstream/pr/790:
  Update to support vertical strips.
  `UINT16_WIDTH` is not a thing
  Re-apply clang-format
  Copied G9M2 entries from kmilos/panny_g9m2
  `uint` is not a type
  Drop spurious spaces, apply clang-format
  Resolving clang warnings treated as errors
  Resolved warnings treated as errors
  Removing list length limit because I realized it is unnecessary.
  First revision of Panasonic RW2 version 8 decoder
* upstream/pr/427:
  Panasonic DC-S5M2X support (data only)
  Panasonic DC-S5M2 support (data only)
* upstream/pr/428:
  Panasonic DC-GH6 support (data only)
* upstream/pr/529:
  Panasonic DC-G9M2 support
* upstream/pr/787:
  Panasonic DC-S9 support (data only)
@LebedevRI LebedevRI linked an issue May 13, 2025 that may be closed by this pull request
@LebedevRI LebedevRI marked this pull request as draft May 13, 2025 18:48
* upstream/pr/813:
  Panasonic DC-S1RM2 support (data only)
@LebedevRI LebedevRI marked this pull request as ready for review May 13, 2025 20:07
@LebedevRI
Copy link
Member Author

This needs changes, but i'll do those after merging the initial variant.

@LebedevRI LebedevRI merged commit e78c3f0 into darktable-org:develop May 13, 2025
64 of 65 checks passed
@LebedevRI LebedevRI deleted the panasonic-v8 branch May 13, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panasonic DC-GH6 raws are version 8 - new decompressor needed
3 participants