Skip to content

refactor: use CommunicationTask to handle sending message to IpfsTask. #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

refactor: use CommunicationTask to handle sending message to IpfsTask. #404

merged 3 commits into from
Mar 7, 2025

Conversation

dariusc93
Copy link
Owner

@dariusc93 dariusc93 commented Mar 7, 2025 •
edited
Loading

This PR is to to begin utilizing CommunicationTask to send commands to the task handling commands while polling swarm. This would allow us to cleanup some of the code and make it suitable to abort the task after Ipfs has been completely dropped or if Ipfs::shutdown is called.

Note:

  • We will continue to send the exit command to the task for now but may switch to aborting the task directly when calling Ipfs::shutdown.

@dariusc93 dariusc93 marked this pull request as ready for review March 7, 2025 05:01
dariusc93
dariusc93 commented Mar 7, 2025
View reviewed changes
@dariusc93 dariusc93 merged commit db1c889 into libp2p-next Mar 7, 2025
2 checks passed
@dariusc93 dariusc93 deleted the refactor/channel-task branch March 7, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dariusc93