seth: add function selector and calldata encoding/decoding helpers #757

mds1 · 2021-08-31T21:46:50Z

Leaving this as a draft until I add docs to the README / review the existing comments.

Also looking for feebdack on the method names and syntaxes, e.g. seth slot feels a bit clunky to me, but I don't think there's a more concise way to generalize this

MrChico · 2021-08-31T22:29:50Z

src/seth/libexec/seth/seth-selector

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash


duplicate of seth sig?

Heh, yes, didn't see that one. Will remove this one

one thing that always bothered me about sig, it's very literal... withdraw(uint) is not the same as withdraw(uint256), whereas other functions will correctly account for this, such as seth call 0x.. 'something(uint)' 0x0. But can be left for another day :P

one thing that always bothered me about sig, it's very literal... withdraw(uint) is not the same as withdraw(uint256), whereas other functions will correctly account for this, such as seth call 0x.. 'something(uint)' 0x0. But can be left for another day :P

would it be possible to fix this just by replacing uses of standalone uint with uint256? It's the only type with that behavior iirc

I'll look into how seth call does it, but worst case it should be easy to find/replace uint and int with uint256 and int256 before hashing

the memory bs also screws it up

Good call, just pushed a version of seth sig that will behave the same as seth call

MrChico · 2021-08-31T22:36:07Z

src/seth/libexec/seth/seth-4byte-decode

+### Usage: seth 4byte-decode <calldata>
+###
+### Querys 4byte.directory to find matching signatures and prompts the user to to select one. The selected
+### signature will be used to decode the calldata.


could be nice to have an --optimistic (I feel lucky) flag to this if we wanna build some larger pipeline where we can't be interactive

I was thinking that too, just wasn't sure of how we'd want to do it. You can sometimes deduce which sig is the correct one from the calldata, but that can get hairy for complex sigs, and you can't always deduce it

For now I learn towards a simpler approach of having --optimistic use the oldest sig 4byte.directory has. Anecdotally this seems to often be the desired one (or at least it was the for the ERC20 methods I used for testing)

wdyt about a --id flag that accepts either an id number or earliest/latest

Hmm, what would be the use case for specifying an ID? If you know the ID then presumably you also know the function signature, meaning you could use seth --calldata-decode instead of seth 4byte-decode

meh mainly for the ability to specify earliest/latest

and id is shorter than using the full sig 🤷

That seems reasonable enough to me, being able to toggle earliest/latest is nice

Would love some help with my --id flag here. In f45ee07 I pushed an attempt that works if I set the env var manually but not with the --id flag

nanexcool · 2021-08-31T23:46:23Z

that and `int` to `int256` I believe

…

On Tue, Aug 31, 2021 at 6:44 PM t11s ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/seth/libexec/seth/seth-selector <#757 (comment)>: > @@ -0,0 +1,11 @@ +#!/usr/bin/env bash one thing that always bothered me about sig, it's very literal... withdraw(uint) is not the same as withdraw(uint256), whereas other functions will correctly account for this, such as seth call 0x.. 'something(uint)' 0x0. But can be left for another day :P would it be possible to fix this just by replacing uses of standalone uint with uint256? It's the only type with that behavior iirc — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#757 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAM2HT2VVIVMGGTNUQHOVTT7VSPVANCNFSM5DFBN7XQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

more info: https://github.com/dapphub/dapptools/pull/757\#discussion_r699738498

transmissions11 · 2021-09-06T09:32:29Z

src/seth/libexec/seth/seth-slot

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+### seth-slot -- Prints the slot number for the specified mapping type and input data


slot seems too generic for what this actually is imo 😅

wdyt about changing to mapping-slot or somethin?

I vote seth index

seth index it will be! Sorry for the delay here, hoping to finish this PR up this week

reference: https://github.com/dapphub/dapptools/pull/757\#discussion_r702754284

mds1 · 2021-09-09T22:24:33Z

Ok everything should now be working and ready for review/testing!

d-xo · 2021-09-12T11:21:24Z

src/seth/README.md

+Show the timestamp of a block (the latest block by default).
+
+    seth age [--block <block>]


Looks like a lil copy / paste error here...

Fixed in d523c2e

d-xo · 2021-09-12T11:22:36Z

src/seth/libexec/seth/seth-index

+### seth-index -- Prints the slot number for the specified mapping type and input data
+### Usage: seth index <fromtype> <totype> <fromvalue> <slot> [<lang>]
+###
+### Prints the slot number for the specified mapping type and input data. For example,
+### the balances mapping in DAI is slot 2, so to find the slot where the balance 
+### is stored for <account>, use
+###     seth-index address uint256 <account> 2


Can we document the allowed values for <lang> here pls

Done in d523c2e

d-xo · 2021-09-12T11:23:45Z

src/seth/libexec/seth/seth-index

+###     seth-index address uint256 <account> 2
+
+set -e
+


Can we print usage info we don't have the expected number of params, right now if I run seth index it shows a fairly inscrutable error from hevm:

> seth index hevm: wrong number of arguments:0: [] CallStack (from HasCallStack): error, called at hevm-cli/hevm-cli.hs:984:11 in main:Main

Done in d523c2e

d-xo · 2021-09-12T11:26:53Z

src/seth/libexec/seth/seth-index

+set -e
+
+if [[ $5 = 'vyper' || $5 = 'vy' || $5 = 'v' ]]; then
+  # note: not guaranteed to work for all Vyper versions since storage layout is not yet stable


Is it maybe worth putting some warning on std err here?

Added in d523c2e

d-xo · 2021-09-12T12:17:11Z

src/seth/libexec/seth/seth-abi-encode

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+### seth-abi-encode -- ABI encode values, and prints the encoded values without the function signature
+### Usage: seth abi-encode <sig> [<args>]


Does it make sense to accept a tuple of types and then automatically add some dummy function signature just as an internal implementation detail?

You could, but IMO we should keep the current sig input format since it's more familiar (i.e. used in other seth methods) and as a result more composable with other methods (i.e. outputs from the 4byte methods).

Also noticed a docs issue with this command, so fixed in d523c2e

d-xo · 2021-09-12T12:17:59Z

These are very nice! Thanks a lot ✨

Can you please add a changelog entry with the new commands?

more info: https://github.com/dapphub/dapptools/pull/757\#discussion_r699738498

reference: https://github.com/dapphub/dapptools/pull/757\#discussion_r702754284

mds1 · 2021-09-12T15:36:11Z

@d-xo addressed all your comments!

MrChico reviewed Aug 31, 2021

View reviewed changes

mds1 referenced this pull request in mds1/dapptools Sep 2, 2021

seth: make seth sig more robust

c96ab9a

more info: https://github.com/dapphub/dapptools/pull/757\#discussion_r699738498

mds1 force-pushed the seth-helpers branch 2 times, most recently from 356811b to f45ee07 Compare September 2, 2021 20:29

transmissions11 reviewed Sep 6, 2021

View reviewed changes

mds1 referenced this pull request in mds1/dapptools Sep 9, 2021

seth: rename seth-slot to seth-index

deb56f4

reference: https://github.com/dapphub/dapptools/pull/757\#discussion_r702754284

mds1 marked this pull request as ready for review September 9, 2021 22:24

d-xo reviewed Sep 12, 2021

View reviewed changes

mds1 added 8 commits September 12, 2021 08:28

seth: add storage slot and calldata encoding helpers

4bc8f4d

seth: make seth sig more robust

8dbc0c3

more info: https://github.com/dapphub/dapptools/pull/757\#discussion_r699738498

seth: allow id to be specified for 4byte decoding

7580325

seth: fix 4byte-decode --id param

f23a1fc

seth: rename seth-slot to seth-index

3cd32f9

reference: https://github.com/dapphub/dapptools/pull/757\#discussion_r702754284

seth (docs): update README and function comments

1d517e0

seth (style): remove unnecessary line break when --id is used

2b400a4

seth (docs): various README and usage info updates

d523c2e

mds1 force-pushed the seth-helpers branch from b8f25af to d523c2e Compare September 12, 2021 15:32

seth (docs): update changelog

f058816

d-xo approved these changes Sep 12, 2021

View reviewed changes

d-xo merged commit c26db40 into dapphub:master Sep 12, 2021

mds1 mentioned this pull request Oct 7, 2021

Fix seth sig #818

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

seth: add function selector and calldata encoding/decoding helpers #757

seth: add function selector and calldata encoding/decoding helpers #757

mds1 commented Aug 31, 2021

MrChico Aug 31, 2021

mds1 Aug 31, 2021

nanexcool Aug 31, 2021

transmissions11 Aug 31, 2021

mds1 Sep 1, 2021

MrChico Sep 1, 2021

mds1 Sep 2, 2021

MrChico Aug 31, 2021

mds1 Aug 31, 2021

transmissions11 Sep 1, 2021

mds1 Sep 1, 2021

transmissions11 Sep 1, 2021

mds1 Sep 1, 2021

mds1 Sep 2, 2021

nanexcool commented Aug 31, 2021 via email

transmissions11 Sep 6, 2021 •

edited

Loading

MrChico Sep 9, 2021

transmissions11 Sep 9, 2021

mds1 Sep 9, 2021

mds1 commented Sep 9, 2021

d-xo Sep 12, 2021

mds1 Sep 12, 2021 •

edited

Loading

d-xo Sep 12, 2021

mds1 Sep 12, 2021 •

edited

Loading

d-xo Sep 12, 2021 •

edited

Loading

mds1 Sep 12, 2021 •

edited

Loading

d-xo Sep 12, 2021

mds1 Sep 12, 2021 •

edited

Loading

d-xo Sep 12, 2021

mds1 Sep 12, 2021 •

edited

Loading

d-xo commented Sep 12, 2021

mds1 commented Sep 12, 2021

		@@ -0,0 +1,18 @@
		#!/usr/bin/env bash
		### seth-slot -- Prints the slot number for the specified mapping type and input data

		Show the timestamp of a block (the latest block by default).

		seth age [--block <block>]

seth: add function selector and calldata encoding/decoding helpers #757

seth: add function selector and calldata encoding/decoding helpers #757

Conversation

mds1 commented Aug 31, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nanexcool commented Aug 31, 2021 via email

transmissions11 Sep 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mds1 commented Sep 9, 2021

Choose a reason for hiding this comment

mds1 Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mds1 Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

d-xo Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

mds1 Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mds1 Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mds1 Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

d-xo commented Sep 12, 2021

mds1 commented Sep 12, 2021

transmissions11 Sep 6, 2021 •

edited

Loading

mds1 Sep 12, 2021 •

edited

Loading

mds1 Sep 12, 2021 •

edited

Loading

d-xo Sep 12, 2021 •

edited

Loading

mds1 Sep 12, 2021 •

edited

Loading

mds1 Sep 12, 2021 •

edited

Loading

mds1 Sep 12, 2021 •

edited

Loading