Skip to content

Add function to backfill play description #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2023
Merged

Add function to backfill play description #18

merged 2 commits into from
Jan 11, 2023

Conversation

EricLin-wk
Copy link
Contributor

  • Add Admin function updateDescription to update Play's description metadata
  • MetadataViews.Display should use Play's description metadata if it exists

@EricLin-wk EricLin-wk requested a review from a team as a code owner January 5, 2023 02:10
joshuahannan
joshuahannan approved these changes Jan 5, 2023
View reviewed changes
Copy link

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd recommend a quick blog post to let the All day dev community know that an upgrade is coming

bshahid331
bshahid331 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@bshahid331 bshahid331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricLin-wk EricLin-wk merged commit dd973e0 into main Jan 11, 2023
@EricLin-wk EricLin-wk deleted the ewlin/upd_play_description branch January 11, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshahid331 bshahid331 bshahid331 approved these changes

@joshuahannan joshuahannan joshuahannan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricLin-wk @bshahid331 @joshuahannan