Implement core NFT views to conform to Flow NFT Metadata standard #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadief
reviewed
Oct 21, 2022
sadief
reviewed
Oct 21, 2022
contracts/AllDay.cdc
Outdated
| //------------------------------------------------------------ | ||
|
|
||
| // The address to which royalties should be deposited | ||
| pub fun RoyaltyAddress() : Address { |
There was a problem hiding this comment.
Do we need to have a RoyaltyAddress in order to implement the metadata views?
There was a problem hiding this comment.
No, I'll get rid of this method and move the variable into resolveView()
sadief
reviewed
Oct 21, 2022
lib/go/test/allday_test.go
Outdated
| mediasView := result[3] | ||
| editions := mediasView.Fields[0].(cadence.Array) | ||
| assert.Equal(t, "https://assets.nflallday.com/editions/1/media/image?format=jpeg&width=512", | ||
| editions.Values[0].(cadence.Struct).Fields[0].(cadence.Struct).Fields[0].ToGoValue()) |
There was a problem hiding this comment.
nice tests! You could have a helper func that takes in the index and editions and returns the result of
editions.Values[0].(cadence.Struct).Fields[0].(cadence.Struct).Fields[0].ToGoValue())
that you could use in the assert.Equal just to make the tests a little less verbose
|
The Metadata Views implementations LGTM |
sadief
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Core NFT Views from the MetadataViews contract to conform to the Flow NFT Metadata standard https://www.flow-nft-catalog.com/