GenericSchemeMultiCall : Simplification. + Schemeconstraint #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
changed the title
ben-kaufman
approved these changes
Oct 13, 2020
nicoelzer
reviewed
Oct 13, 2020
| uint256 public periodSize; | ||
| uint256 public periodLimitWei; | ||
|
|
||
| mapping(uint256=>uint256) public periodSpendingTokens; |
There was a problem hiding this comment.
Unused mapping can be removed
nicoelzer
reviewed
Oct 13, 2020
| function isAllowedToPropose( | ||
| address[] calldata _contractsToCall, | ||
| bytes[] calldata _callsData, | ||
| uint256[] calldata, |
There was a problem hiding this comment.
uint256[] calldata > uint256[] calldata _values?
There was a problem hiding this comment.
yes, because the interface defined that function and there is no use for values at this function
nicoelzer
reviewed
Oct 13, 2020
| return true; | ||
| } | ||
|
|
||
| function observationIndex() public view returns (uint256) { |
There was a problem hiding this comment.
@orenyodfat this could become vulnerable to overflows if the period is set to a super low level, I would propose to add a require in the initialize() to set the period to a min limit as of 7days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.