Add CL4RRedeemer #791
Merged
Add CL4RRedeemer #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
reviewed
Sep 22, 2020
orenyodfat
reviewed
Sep 22, 2020
orenyodfat
reviewed
Sep 22, 2020
orenyodfat
reviewed
Sep 22, 2020
orenyodfat
reviewed
Sep 29, 2020
orenyodfat
reviewed
Sep 29, 2020
contracts/schemes/CL4RRedeemer.sol
Outdated
|
|
||
| /** | ||
| * @title A scheme for redeeming a ContinuousLocking4Reputation contract used in a different DAO. | ||
| * This is used to migrate from an older DAO to a new one while the older DAO has an active ContinuousLocking4Reputation |
There was a problem hiding this comment.
This is used - > This contract can be use
orenyodfat
reviewed
Sep 29, 2020
contracts/schemes/CL4RRedeemer.sol
Outdated
| /** | ||
| * @title A scheme for redeeming a ContinuousLocking4Reputation contract used in a different DAO. | ||
| * This is used to migrate from an older DAO to a new one while the older DAO has an active ContinuousLocking4Reputation | ||
| * Using it should be done by initiaalizing this contract s a scheme in the new DAO, |
There was a problem hiding this comment.
initiaalizing -> initializing
contract s a scheme -> contract as a scheme
orenyodfat
reviewed
Sep 29, 2020
contracts/schemes/CL4RRedeemer.sol
Outdated
| * @title A scheme for redeeming a ContinuousLocking4Reputation contract used in a different DAO. | ||
| * This is used to migrate from an older DAO to a new one while the older DAO has an active ContinuousLocking4Reputation | ||
| * Using it should be done by initiaalizing this contract s a scheme in the new DAO, | ||
| * with the old ContinuousLocking4Reputation as an init parameter. |
There was a problem hiding this comment.
as an init parameter (_ct4r)
orenyodfat
reviewed
Sep 29, 2020
contracts/schemes/CL4RRedeemer.sol
Outdated
| * This is used to migrate from an older DAO to a new one while the older DAO has an active ContinuousLocking4Reputation | ||
| * Using it should be done by initiaalizing this contract s a scheme in the new DAO, | ||
| * with the old ContinuousLocking4Reputation as an init parameter. | ||
| * Then the old ContinuousLocking4Reputation should be unregistered as a scheme from the older DAO so |
There was a problem hiding this comment.
Note : the old ContinuousLocking4Reputation should be unregistered as a scheme from the older ....
|
Fixed the description @orenyodfat |
orenyodfat
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.