Skip to content

Common token #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2020
Merged

Common token #753

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca10d73
firstr version
May 19, 2020
0745e59
fix
May 19, 2020
508c132
tests
May 20, 2020
54f98db
split long controller tests
May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions contracts/misc/CommonToken.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
pragma solidity ^0.5.17;

import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/StandaloneERC20.sol";
import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/IERC20.sol";


/**
* @title CommonToken, base on zeppelin contract.
* @dev ERC20 compatible token. It is a mintable, burnable token(onlyOwner)
*/
contract CommonToken is StandaloneERC20 {

/**
* @dev Destroys `amount` tokens from the caller.
*
* See {ERC20-_burn}.
*/
function burn(uint256 amount) public onlyMinter {
Copy link
Contributor

@jellegerbrandy jellegerbrandy May 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need:

burn(address account, uint256 amount) public onlyMinter {
  _burn(account, amount)
}

_burn(_msgSender(), amount);
}
}