refactor: Change the location of the commit code and add some tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internals of commit should be moved to a new function. This way we can sandwich a commit async call between commit and runCommitAsync.
Make sure commit behaves the same way as before.
Commit tests added to ensure that commit behaves the same way as before.
The tests should pass before we make changes to commit.
One of the mocks does not need to be written twice
…t-tests' of https://github.com/danieljbruce/nodejs-datastore into nodejs-transaction-redesign-feature-branch-2-adding-commit
This is going to be a useful test for mocking out various layers to make sure they work the same way as before.
The mocked transaction wrapper should reset all mocked gapic functions and not have to be told which ones to reset.
Gapic mocked tests for run aggregation query need to be written that use the mock transaction object.
The runQuery tests are finished so we can use this to take apart the function from end to end.
The get tests now make sure that the data coming back from the gapic layer results in the same values for users.
try/catch logic in the test suite is added so that errors bubble up to the test runner and it is easier to see why tests failed
…nieljbruce/nodejs-datastore into nodejs-transaction-redesign-feature-branch-1a-add-commit-tests
…t-tests' of https://github.com/danieljbruce/nodejs-datastore into nodejs-transaction-redesign-feature-branch-2-adding-commit # Conflicts: # src/transaction.ts
…mit' of https://github.com/danieljbruce/nodejs-datastore into nodejs-transaction-redesign-feature-branch-2a-adding-commit-and-tests # Conflicts: # test/transaction.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add description.