-
Notifications
You must be signed in to change notification settings - Fork 8
Add pyproject.toml for Custom Node Registry #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hey @daniel-lewis-ab, wanted to send a small nudge and ask if you had any questions! |
🤔
I'm currently feeling a bit off/tired/down and taking a short break where I
can. I'm about a week from selling my house and have been renovating, am
working more than full time with Salt, and doing this, and some other
things. In all of those aspects, I am tired and waiting for something.
I'm going for a walk, and I'm hoping to face this in about a week or so.
…On Thu, Jun 20, 2024 at 7:04 AM haohaocreates ***@***.***> wrote:
hey @daniel-lewis-ab <https://github.com/daniel-lewis-ab>, wanted to send
a small nudge and ask if you had any questions!
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC36LNYUKMF6RZR3HFTUMETZILHMZAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGYZTCNJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey man that sounds like a lot of things going on 🥺 - hope you can power
through 💪💪💪! Take your time!
Hope you rest up Daniel!
On Thu, Jun 20, 2024 at 9:53 AM Daniel Lewis ***@***.***>
wrote:
… 🤔
I'm currently feeling a bit off/tired/down and taking a short break where
I
can. I'm about a week from selling my house and have been renovating, am
working more than full time with Salt, and doing this, and some other
things. In all of those aspects, I am tired and waiting for something.
I'm going for a walk, and I'm hoping to face this in about a week or so.
On Thu, Jun 20, 2024 at 7:04 AM haohaocreates ***@***.***>
wrote:
> hey @daniel-lewis-ab <https://github.com/daniel-lewis-ab>, wanted to
send
> a small nudge and ask if you had any questions!
>
> —
> Reply to this email directly, view it on GitHub
> <
#2 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AC36LNYUKMF6RZR3HFTUMETZILHMZAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGYZTCNJTG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG3AD2IU666YQ2AXCOR5VX3ZILNFVAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQG43DMOJTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Appreciate it. I think everyone's got things, but there's a value in
honesty when you're around people who aren't hostile. I hope you're doing
well too, and appreciate your contributions to the community.
On Thu, Jun 20, 2024 at 9:33 AM haohaocreates ***@***.***>
wrote:
… Hey man that sounds like a lot of things going on 🥺 - hope you can power
through 💪💪💪! Take your time!
Hope you rest up Daniel!
On Thu, Jun 20, 2024 at 9:53 AM Daniel Lewis ***@***.***>
wrote:
> 🤔
>
> I'm currently feeling a bit off/tired/down and taking a short break
where
> I
> can. I'm about a week from selling my house and have been renovating, am
> working more than full time with Salt, and doing this, and some other
> things. In all of those aspects, I am tired and waiting for something.
>
> I'm going for a walk, and I'm hoping to face this in about a week or so.
>
> On Thu, Jun 20, 2024 at 7:04 AM haohaocreates ***@***.***>
> wrote:
>
> > hey @daniel-lewis-ab <https://github.com/daniel-lewis-ab>, wanted to
> send
> > a small nudge and ask if you had any questions!
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
>
#2 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AC36LNYUKMF6RZR3HFTUMETZILHMZAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGYZTCNJTG4>
>
> > .
> > You are receiving this because you were mentioned.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
#2 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/BG3AD2IU666YQ2AXCOR5VX3ZILNFVAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQG43DMOJTGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC36LNZDZCMFQXDCLCDA6HLZILY4DAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQHE4TENBSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey Daniel!!
Lmk if you are still running into issues with name changing?
…On Sat, Jun 29, 2024 at 3:51 PM Daniel Lewis ***@***.***> wrote:
Merged #2 <#2> into
main.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG3AD2MXR7H4BSKNIQ7ZU33ZJ4F3VAVCNFSM6AAAAABJJ3PKLCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM2DANJXGEYTMOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can
Action Required:
@
sign on your registry profile).If you want to publish the node manually, install the cli by running
pip install comfy-cli
, then runcomfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!