-
Notifications
You must be signed in to change notification settings - Fork 1
Description
NB I hit Enter
my accident before filling it in
This is a follow up to #245 PR which introduces default behavior of quick checks of dandisets by their modification times to decide either to skip or go through assets and reflect changes. In the mode of --verify-timestamps
it might happen that we would be going through assets while dandiset gets updated, and by the time we get to some asset the done previously check based solely on date would no longer be valid. So I think that may be error_on_change
should actually be a callback/fixture for a specific dandiset to re-ask that dandiset modification datetime, so if we detected some change, and see that modification time did change from previous one -- we are all good an do not need to error out on that run for that or any subsequent check like that.
Since situation is still hypothetical, I decided to just file an issue instead of requesting changes to that PR. But if you @jwodder think it is worthwhile implementing right there -- go ahead.