Fix formatting of approved user message template #2373
Conversation
| @@ -1,8 +1,7 @@ | |||
| {% autoescape off %} | |||
| Dear {{ greeting_name }}, | |||
|
|
|||
| Your DANDI account has been approved. You can go to {{ dandi_web_app_url }} and login with your GitHub account | |||
| to start creating dandisets and uploading data. | |||
| Your DANDI account has been approved. You can go to {{ dandi_web_app_url }} and login with your GitHub account to start creating dandisets and uploading data. | |||
There was a problem hiding this comment.
note @NEStock : do you have vendorization patch for this by any chance? ;-)
There was a problem hiding this comment.
@yarikoptic we replaced instances of the text "DANDI" with "EMBER-DANDI" by hand.
And then dandi_web_app_url is set in dandi-infrastructure, so we were able to change that easily (https://github.com/aplbrain/dandi-infrastructure/blob/f8c0f4b437aa0fcb6beee9d75602e8cae49f2c32/terraform/api.tf#L47)
Here is the EMBER version of this file for reference: https://github.com/aplbrain/dandi-archive/blob/527b818a664e1a4c8878b1131699ff5ec7376097/dandiapi/api/templates/api/mail/approved_user_message.txt#L4
There was a problem hiding this comment.
we should review/decide on what is the best way to organize such elements for "vendorization"... I guess we should aim by default to propagate all the config variables in here but allow for a complete overload of the messages happen a particular archive needs more specific customization...
|
🚀 PR was released in |
Since the current template results in the following message: