Skip to content

Check to see if cookies are enabled for banner message #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Check to see if cookies are enabled for banner message #2359

merged 1 commit into from
Apr 28, 2025

Conversation

naglepuff
Copy link
Contributor

@naglepuff naglepuff commented Apr 28, 2025 •
edited
Loading

Fixes #2271

Changes

  • Leverages the existing cookiesEnabled function (using a pattern employed elsewhere in the code) to change the message displayed in the cookie banner depending on whether the user has cookies enabled
  • Re-enables the test that checks whether the correct cookie message is shown

@naglepuff naglepuff requested a review from mvandenburgh April 28, 2025 15:41
@mvandenburgh mvandenburgh added tests Add or improve existing tests patch Increment the patch version when merged labels Apr 28, 2025
@naglepuff naglepuff merged commit 37c7075 into master Apr 28, 2025
12 of 14 checks passed
@naglepuff naglepuff deleted the 2271-cookies-disabled-banner branch April 28, 2025 21:05
@NEStock
Copy link
Contributor

NEStock commented Apr 29, 2025 •
edited
Loading

@naglepuff Would you be able to share how you got the test-e2e check to pass after failing here? We're seeing the same error in our EMBER fork of dandi-archive https://github.com/aplbrain/dandi-archive/actions/runs/14734260376/job/41356202938?pr=64. We just pulled the latest code from dandi-archive/master and are still seeing the error, so I'm wondering if it was a code change or something else that enabled passing? thanks in advance!

Edit: Resolved
In order to fix the failing test-e2e job, we needed to delete the cache being used (Actions -> Caches -> delete appropriate cache)

@dandibot
Copy link
Member

🚀 PR was released in v0.9.0 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released. tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookie banner no longer notifies user when cookies are disabled
4 participants
@naglepuff @NEStock @dandibot @mvandenburgh