-
Notifications
You must be signed in to change notification settings - Fork 14
Update sorting controls for Dandisets page #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should these controls not be on the left side, instead of the right? Since it's already a prominent change in the dandisets page, it might be easier for people to adjust if it's around where the old sort options were. cc @jtomeck FWIW I really like the change. |
That's a fair point. I don't necessarily have a preference, so I'm interested in seeing what others have to say. It's a straightforward adjustment to make if there's a consensus that it should be moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest code changes this look good to me. I just had one question about the design.
GitHub is also reporting a bunch of linting errors in the "Files changed" view for me, but CI is passing which is strange. I bet it's something wrong with how I set up linting for Vue 3. Either way, we can figure this out in a follow up since it's unrelated to this PR
@naglepuff now that #2360 is merged, if you rebase this PR on |
Co-authored-by: Mike VanDenburgh <[email protected]>
b2e7fee
to
a1016da
Compare
a1016da
to
cfdb5a6
Compare
@mvandenburgh I see you just approved so sorry to make you take another look, but I worked on implementing the suggestions discussed earlier today |
cfda90f
to
01f1eae
Compare
@jjnesbitt how about this? |
That looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I approved this prematurely before - but agreed, this looks great!
🚀 PR was released in |
Fix #1764
Fix #2176
Changes
Replaces the current sorting controls on the Dandisets page with a more compact, mobile-friendly widget. Based on the design by @jtomeck outlined in #1764.
Demo video
compact_sort_widget_demo.mp4