Skip to content

Clean up setup.py #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

Clean up setup.py #2324

merged 3 commits into from
Apr 17, 2025

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Apr 17, 2025

  • Removes some dependencies that are unused.
  • Moves a test-only dependency out of the prod dependencies and into the test extra
  • Attempt to unpin DRF; I'll pop that commit off it still fails CI. Update: this did not work. I popped off that commit.
  • Fix minor issue with Django version classifier in setuptools package metadata

This library is only used in tests and does not need to be installed in
the production environment.
This dependency is not used anywhere in the codebase.
This doesn't matter too much since we do not distribute the `dandiapi`
package as an installable package, but we are now on Django 4.2.
@mvandenburgh mvandenburgh marked this pull request as ready for review April 17, 2025 15:46
@mvandenburgh mvandenburgh requested a review from jjnesbitt April 17, 2025 15:47
@mvandenburgh mvandenburgh added the dependencies Update one or more dependencies version label Apr 17, 2025
@mvandenburgh mvandenburgh merged commit 8e0e3c2 into master Apr 17, 2025
10 checks passed
@mvandenburgh mvandenburgh deleted the dependency-fixes branch April 17, 2025 16:00
@dandibot
Copy link
Member

🚀 PR was released in v0.8.0 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants