Skip to content

Show empty dandisets for search by default #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

naglepuff
Copy link
Contributor

Fixes #2034

Changes

Update the DandisetsPage component by initializing the showEmpty ref to have a value of true if the component is being used to display search results.

@naglepuff naglepuff force-pushed the issue-2034-more-inclusive-search-results branch from 53ffa4b to 4b2fbdd Compare April 8, 2025 15:36
@naglepuff naglepuff marked this pull request as ready for review April 9, 2025 15:08
@naglepuff naglepuff requested a review from mvandenburgh April 9, 2025 15:08
@naglepuff naglepuff merged commit 1fef5f9 into master Apr 10, 2025
2 checks passed
@naglepuff naglepuff deleted the issue-2034-more-inclusive-search-results branch April 10, 2025 16:10
@mvandenburgh mvandenburgh added the patch Increment the patch version when merged label Apr 16, 2025
@dandibot
Copy link
Member

🚀 PR was released in v0.5.0 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disregard "empty" and "draft" filters for search results
3 participants