Skip to content

Fix v-switch margins and color #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix v-switch margins and color #2290

merged 2 commits into from
Apr 8, 2025

Conversation

mvandenburgh
Copy link
Member

Fixes #2249
Fixes #2289

Before:

switch_broken

After:

switch_fixed2

@mvandenburgh mvandenburgh requested a review from jjnesbitt April 7, 2025 18:02
@jjnesbitt
Copy link
Member

Not to be a stickler but it seems the switch is still slightly cut off on the left side.
image

This adds some horizontal margins to prevent the `v-switch` from being
cut off.
Vuetify 2 did this by default, but Vuetify 3 does not.
@mvandenburgh mvandenburgh changed the title Switch to comfortable variant of v-switch Fix v-switch margins and color Apr 7, 2025
@mvandenburgh
Copy link
Member Author

Since switching to the comfortable variant doesn't fix the issue, and also changes the vertical margins to be larger than in the Vuetify 2 app, I just backed that out and added some additional horizontal margins.

@mvandenburgh mvandenburgh merged commit bfdbb47 into master Apr 8, 2025
2 checks passed
@mvandenburgh mvandenburgh deleted the fix-v-switch branch April 8, 2025 15:42
@mvandenburgh mvandenburgh added the patch Increment the patch version when merged label Apr 16, 2025
@dandibot
Copy link
Member

🚀 PR was released in v0.5.0 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dandiset list filter switches are cut off Show options don't provide color distinctions between on/off
3 participants