Skip to content

Fix link dropdown text on mobile #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Fix link dropdown text on mobile #2266

merged 2 commits into from
Apr 3, 2025

Conversation

mvandenburgh
Copy link
Member

Fixes #2262

In Vuetify 2, the text prop of the v-list-item component is a boolean that applies a certain styling to the component. In Vuetify 3, the text prop represents the textual content of the v-list-item component. That resulted in it being interpreted as an empty string, resulting in those items not being displayed.

In Vuetify 2, the `text` prop of the `v-list-item` component is a
boolean that applies a certain styling to the component. In Vuetify 3,
the `text` prop represents the textual content of the `v-list-item`
component. That resulted in it being interpreted as an empty string,
resulting in the issue where those items were not being displayed.
The Vuetify 3 v-list-item component no longer applies a
`justify-space-between`-like style to its children, so we need to
do it ourselves to maintain visual parity with the old UI.
@mvandenburgh mvandenburgh requested a review from jjnesbitt March 28, 2025 18:03
@mvandenburgh mvandenburgh changed the title Remove text prop from v-list-item Fix link dropdown text on mobile Mar 28, 2025
@mvandenburgh mvandenburgh merged commit fde9ce8 into master Apr 3, 2025
2 checks passed
@mvandenburgh mvandenburgh deleted the fix-mobile-links branch April 3, 2025 19:35
@mvandenburgh mvandenburgh added the patch Increment the patch version when merged label Apr 16, 2025
@dandibot
Copy link
Member

🚀 PR was released in v0.5.0 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapsed menu (when width is small) is gone?
3 participants