Skip to content

update test doi server #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

update test doi server #2241

merged 1 commit into from
Apr 3, 2025

Conversation

satra
Copy link
Member

@satra satra commented Mar 26, 2025

Based on comment here: datacite/datacite#2311 (comment)

yarikoptic
yarikoptic approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried that curl invocation in referenced issue and indeed needs this fixed target service. Tests also pass -- so likely is the right thing to do

@yarikoptic yarikoptic added patch Increment the patch version when merged client Pertains to the web client labels Apr 2, 2025
@mvandenburgh mvandenburgh removed the patch Increment the patch version when merged label Apr 3, 2025
@mvandenburgh
Copy link
Member

fyi I removed the patch label, since we don't want to release the Vue 3 client yet.

@mvandenburgh mvandenburgh merged commit f58e3e2 into master Apr 3, 2025
2 checks passed
@mvandenburgh mvandenburgh deleted the fix/test-doi branch April 3, 2025 19:42
@yarikoptic yarikoptic mentioned this pull request Apr 7, 2025
Merged
@mvandenburgh mvandenburgh added the internal Changes only affect the internal API label Apr 16, 2025
@dandibot
Copy link
Member

🚀 PR was released in v0.5.0 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic approved these changes

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
client Pertains to the web client internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satra @mvandenburgh @dandibot @yarikoptic