Fix a case where draft asset summaries could become stale #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an edge case where a draft asset summary might become stale by ensuring that when a dandiset is published, the associated asset summary from the published version is copied to the draft version. Key changes include:
- Adding a test to verify that publishing a version updates the draft's asset summary.
- Updating the publish service to copy the asset summary from the published version to the draft version.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dandiapi/api/tests/test_version.py | Adds tests to check asset summary consistency after publishing |
| dandiapi/api/services/publish/init.py | Updates the publish routine to sync asset summaries between versions |
danlamanna
force-pushed
the
fix-draft-version-stale-summary
branch
from
4837ecc to
32ccbf4
Compare
There's an edge case where assets can be uploaded and the dandiset can transition into publishing before an appropriate asset summary is computed. When generating the asset summary for the published version it can be copied to the draft to ensure the draft asset summary is always eventually correct.
danlamanna
force-pushed
the
fix-draft-version-stale-summary
branch
from
32ccbf4 to
2989fb3
Compare
mvandenburgh
approved these changes
Apr 8, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an edge case where assets can be uploaded and the dandiset can transition into publishing before an appropriate asset summary for the draft version is computed. When generating the asset summary for the published version it can be copied to the draft to ensure the draft asset summary is always eventually correct.