Add admin and description fields to AuditRecord model

[jjnesbitt]

Closes #2224

This introduces two new fields to the AuditRecord model: admin and description. These fields are to be used in conjunction, when the modification of something in the system is done through administrative means, and not the normal workflow. An example of this would be if we were to fix some malformed data that existing in some versions or assets.

[waxlamp]

Looks good overall, but I want to strengthen the check constraint and reduce the "line noise" of the common params abstraction.

[waxlamp]

We had talked about making the username column nullable, but I had forgotten that column (along with the user_email and user_fullname columns) is text, not a foreign key to a user model. Does that mean we don't need these columns to be nullable at all, and can instead leave them blank or use stand-in data (like "admin", "[email protected]", and "DANDI admin team")?

If yes, then this is ready to merge; otherwise let's discuss what we should do.

[jjnesbitt]

We had talked about making the username column nullable, but I had forgotten that column (along with the user_email and user_fullname columns) is text, not a foreign key to a user model. Does that mean we don't need these columns to be nullable at all, and can instead leave them blank or use stand-in data (like "admin", "[email protected]", and "DANDI admin team")?

If yes, then this is ready to merge; otherwise let's discuss what we should do.

Correct, my vote would be that we just leave them blank, instead of allow null.

I'm realizing that we may want to require those fields be non-empty if admin=False. Although you could make the case it falls outside the scope of this PR (since if that's desired, the constraint should have already existed anyway).

If you agree we shouldn't address that here and now, then I agree with your previous comment that this is ready to merge.

[mvandenburgh]

Correct, my vote would be that we just leave them blank, instead of allow null.

I agree. In addition to the reasons already stated, there's also this rule - https://docs.astral.sh/ruff/rules/django-nullable-model-string-field/.

[waxlamp]

I'm realizing that we may want to require those fields be non-empty if admin=False

Good point. Please go ahead and do that in a followup PR.

[dandibot]

🚀 PR was released in v0.5.0 🚀