Add calculate_sha256 management command to trigger (re)computation for a blob #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
yarikoptic
force-pushed
the
enh-calc_sha256
branch
2 times, most recently
from
f3b32c0 to
dff7f98
Compare
yarikoptic
force-pushed
the
enh-calc_sha256
branch
from
dff7f98 to
3d31391
Compare
|
In 4 days this non-draft PR will celebrate its 3rd month without feedback. @waxlamp please attend to decide on its destiny one way or another. |
|
ping @waxlamp @jjnesbitt @mvandenburgh . I felt like this is a trivial PR which could get either blessed or rejected speedily. |
waxlamp
force-pushed
the
enh-calc_sha256
branch
from
1f30b01 to
ccf08bf
Compare
|
so, overall code is good and we could proceed? |
waxlamp
approved these changes
Oct 4, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to specify either blob id (where it applies) or asset id since that is the id we typically know for which a blob lacks sha256.
Refs:
Monitor for AssetBlobs with undefined sha256 #471
assets can still be missing sha256 #1578
Add retries to sha256 checksum calculation task #1937
has a chance to properly address the underlying issue but IMHO having an interface to trigger such a task manually could still be valuable e.g. in case of that automation failing to perform for some reason etc.