Skip to content

Update Adafruit_NeoPixel library to commit fd74287 #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Update Adafruit_NeoPixel library to commit fd74287 #954

merged 2 commits into from
Mar 11, 2025

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Mar 7, 2025

What

This PR updates the Adafruit_NeoPixel library

Why

To remove the compiler warning

In file included from Software/src/lib/adafruit-Adafruit_NeoPixel/esp.c:23:
/packages/framework-arduinoespressif32-libs/esp32/include/driver/deprecated/driver/rmt.h:18:2: warning: #warning "The legacy RMT driver is deprecated, please use driver/rmt_tx.h and/or driver/rmt_rx.h" [-Wcpp]
   18 | #warning "The legacy RMT driver is deprecated, please use driver/rmt_tx.h and/or driver/rmt_rx.h"
      |  ^~~~~~~

How

By using the latest content available from the Adafruit_NeoPixel library.

dalathegreat
dalathegreat approved these changes Mar 7, 2025
View reviewed changes
Copy link
Owner

@dalathegreat dalathegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍 Feels good to get rid of those compiler warnings!

@lenvm lenvm force-pushed the feature/update-adafruit-neopixel-library-to-fd74287 branch from 164dbd3 to ea5f2e9 Compare March 7, 2025 21:17
@dalathegreat dalathegreat merged commit b6defac into dalathegreat:main Mar 11, 2025
57 checks passed
@dalathegreat
Copy link
Owner

This was a bad change that caused performance issues. Reverting this PR

If I revert the changes, the 10ms function timing drops from 2008us -> 430us

@dalathegreat dalathegreat mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalathegreat dalathegreat dalathegreat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenvm @dalathegreat