Skip to content

chore(cmd/config): fix typos #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Conversation

wanlce
Copy link
Contributor

@wanlce wanlce commented May 20, 2025

Background

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@wanlce wanlce requested a review from a team as a code owner May 20, 2025 13:45
@dae-prow dae-prow bot added the chore label May 20, 2025
jschwinger233
jschwinger233 previously approved these changes May 20, 2025
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

配置文档和example.dae啥的要改吗 不需要

@MarksonHon
Copy link
Contributor

MarksonHon commented May 20, 2025

配置文档和example.dae啥的要改吗 不需要

其实要的,得把 fallback_resolver 加上去,这个值默认是四个八,但是可以自定义的

Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumire88 sumire88 changed the title chore: fix typo chore(cmd/config): fix typos May 22, 2025
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88 sumire88 added the documentation Improvements or additions to documentation label May 22, 2025
@jschwinger233 jschwinger233 merged commit a015e91 into daeuniverse:main May 23, 2025
28 checks passed
@wanlce wanlce deleted the fix_typo branch May 23, 2025 12:18
@dae-prow dae-prow bot mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore documentation Improvements or additions to documentation tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants