stackusage: add human-readable output format option #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @charmitro - thanks for contributing! At a quick glance the changes look good. I'll try take a closer look later this weekend. Please disregard the failing checks (Github actions), it's not related to the PR, and I will fix it separately. |
Hey @d99kris, alright no worries. I just had this in my tree and figured that you could benefit from it. It's a nice addition. |
Add -h flag to display stack sizes in human-readable format (KB/MB/GB) instead of raw bytes. This improves readability when analyzing stack usage for applications with large stack allocations. The implementation adds: - New -h command line option to the wrapper script - SU_HUMAN environment variable to pass the flag to the library - su_format_size_human() function to convert bytes to human-readable units - Conditional formatting in su_log_stack_usage() based on the flag Signed-off-by: Charalampos Mitrodimas <[email protected]>
charmitro
force-pushed
the
human-readable
branch
from
adf4d4b to
2b6c713
Compare
|
It's been merged now. Yes it's a nice addition! Thanks again for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -h flag to display stack sizes in human-readable format (KB/MB/GB) instead of raw bytes. This improves readability when analyzing stack usage for applications with large stack allocations.
The implementation adds: