This repository was archived by the owner on Oct 23, 2024. It is now read-only.
add non-zero weight for returned SRV records #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
thanks @rubbish can you provide a link to the relevant haproxy docs? |
|
@jdef I couldn't find it the haproxy docs (https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#5.3.1), this is something I found in my own testing. But looking at the haproxy source, http://git.haproxy.org/?p=haproxy-1.8.git;a=blob;f=src/dns.c;h=a957710edb2f92e31069844a15338cc8834e8402;hb=HEAD#l527 it has:
|
|
OK, thanks. My gut says that the default weight should be configurable.
Maybe we make that default weight 1 so that SRVs play nice with haproxy by
default. The reason we make it configurable is so that people can roll back
to using 0 if the new default of 1 causes problems in their cluster.
How does that sound?
…On Fri, Jan 26, 2018 at 12:02 PM, Luke Amdor ***@***.***> wrote:
@jdef <https://github.com/jdef> I couldn't find it the haproxy docs (
https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#5.3.1),
this is something I found in my own testing.
But looking at the haproxy source, http://git.haproxy.org/?p=
haproxy-1.8.git;a=blob;f=src/dns.c;h=a957710edb2f92e31069844a15338c
c8834e8402;hb=HEAD#l527 it has:
Make sure weight is at least 1, so that the server will be used.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#515 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLLkVXNkAtiZDNsjCVHTcwtWX7D2bks5tOgVDgaJpZM4RujvT>
.
|
jdef
reviewed
Jan 26, 2018
| `externalon` is a boolean field that controls whether Mesos-DNS serves requests outside of the Mesos domain. The default value is `true`. | ||
| `externalon` is a boolean field that controls whether Mesos-DNS serves requests outside of the Mesos domain. The default value is `true`. | ||
|
|
||
| `srvRecordDefaultWeight` is an int field field that defines what the default weight given to SRV records. The default value is `1`. |
records/config.go
Outdated
| IPSources: []string{"netinfo", "mesos", "host"}, | ||
| EnumerationOn: true, | ||
| MesosAuthentication: httpcli.AuthNone, | ||
| ZkDetectionTimeout: 30, |
There was a problem hiding this comment.
nit: run this through go fmt please
drewkerrigan
suggested changes
Jan 26, 2018
|
should be gtg now |
|
retest this please |
drewkerrigan
approved these changes
Jan 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is zero, services like haproxy see that as a backend that's in maintenance. I couldn't see any problem with making it non-zero.