Support for service accounts, HTTPS and CA certs

[alberts]

No description provided.

[jdef]

build failure

# github.com/mesosphere/mesos-dns/records
records/generator.go:191: invalid operation: token.Claims["uid"] (type jwt.Claims does not support indexing)
records/generator.go:192: invalid operation: token.Claims["exp"] (type jwt.Claims does not support indexing)

[jdef]

lint fail:

cd $GOPATH/src/github.com/mesosphere/mesos-dns && gometalinter --vendor --concurrency=6 --cyclo-over=12 --tests --deadline=300s ./...
records/config.go:85:6:warning: exported type IAMConfig should have comment or be unexported (golint)
records/generator.go:181:6:warning: type authHttpClient should be authHTTPClient (golint)
records/generator.go:200:3:warning: struct field Uid should be UID (golint)
records/config.go:167:16:warning: error return value not checked (defer f.Close()) (errcheck)
records/config.go:186:16:warning: error return value not checked (defer f.Close()) (errcheck)
records/generator.go:217:23:warning: error return value not checked (defer resp.Body.Close()) (errcheck)
records/config.go:127::warning: cyclomatic complexity 16 of function SetConfig() is high (> 12) (gocyclo)

[alberts]

would be great to get rid of scheme entirely

[jdef]

agreed

On Tue, Jun 21, 2016 at 8:50 PM, Albert Strasheim [email protected]
wrote:

In httpcli/doer.go
#443 (comment):

•   return nil, err
  

• }

• if req.Header == nil {

•   req.Header = make(http.Header)
  

• }
• req.Header.Set("Authorization", "token="+authResp.Token)

• return a.client.Do(req)
  +}

+// TLSConfig generates and returns a recommended protocol scheme ("http" or "https") and TLS configuration.
+func TLSConfig(enabled bool, caPool *x509.CertPool) (scheme string, config *tls.Config) {

• scheme = "http"
• if enabled {

•   scheme = "https"
  

would be great to get rid of scheme entirely

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/mesos-dns/pull/443/files/00e2c3a5bbcc291550b5d0707072d2359f991fbb#r67978748,
or mute the thread
https://github.com/notifications/unsubscribe/ACPVLGfoO2tHjZCWuhxhljON0XzwocpPks5qOIbqgaJpZM4I6PXJ
.

[jdef]

this snuck in there, not intentional. didn't see what the changes here imply

[sargun]

Was it not intentional? It seems like a new dep we must vendor.

[jdef]

yeah, we need this for web tokens or something - should have recognized it. going to blame it on low blood sugar

[sargun]

Reasonable.

[alberts]

Managed to start a DC/OS cluster succesfully with this.

[jdef]

🎉

[jdef]

@alberts why is commit c91c973 included here?