-
Notifications
You must be signed in to change notification settings - Fork 7
Validation function #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - adding F1 score and confusion matrix code is very important. I made several comments on most files, but I will summarize my main points below:
- I highly recommend moving away from
.xlsx
files to.csv
or.tsv
files..xlsx
files are much heavier weight than what we need for this project. - I couldn't tell how the model was being trained with 6 different initializations. Please clarify.
- We need to make sure you're properly getting credit for these important contributions! I am seeing grey boxes which indicate that the commit is not properly being attributed to your username. Make sure that the email address you're using to make the commits on your local machine is linked to your github account.
2.process-data/scripts/nbconverted/1.process-ebimage-features.py
Outdated
Show resolved
Hide resolved
Co-Authored-By: Greg Way <[email protected]>
Co-Authored-By: Greg Way <[email protected]>
Co-Authored-By: Greg Way <[email protected]>
Co-Authored-By: Greg Way <[email protected]>
Co-Authored-By: Greg Way <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gwaygenomics that should be it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there - only a couple minor and optional comments and just some additional cleanup required.
- There are still some
confusion_matrix.xlsx
files here. Lets replace them with.csv
files. - Please remove the binary file
~$all_scores.xlsx
Otherwise, looks great! 🎉
Co-Authored-By: Greg Way <[email protected]>
Co-Authored-By: Greg Way <[email protected]>
Co-Authored-By: Greg Way <[email protected]>
…ngle-cell-classifier into validation_function
@wagenrace - confirming that you are not waiting on me - just a couple Then we are good to merge! 🎉 |
issue #26
I performed the following prior to filing this pull request: