-
Notifications
You must be signed in to change notification settings - Fork 234
Add function resource #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix missing quotes in physical_replication_slot doc.
Older versions of postgresql do not support the necessary syntax in CREATE FUNCTION.
Fixed some issues that were exposed by the tests
@cyrilgdn Would you be able to take a look at this? |
@cyrilgdn Any feedback for this change? If it helps, I would be happy to accept longer term responsibility for this resource. I don't know how that would work, but I can tackle bugs and such. |
@dump247 I'll have a look as soon as I can, it could take a few days though, sorry for that. |
No worries. Thank you for taking a look. Let me know if there is anything I can do to facilitate the review. |
@cyrilgdn Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny comment about unnecessary use of transaction that can simplify the code, otherwise it's look good 👍
Many thanks for your work on this and sorry again for the response delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dump247 Thanks a lot for your work on that 👍
FYI, this has just been released in v1.16.0 |
Hi @cyrilgdn , Would it be possible to add support for the "database" parameter for this ressource as well ? Thank you |
The use case for this resource is setting up datadog agent access. It requires defining a
datadog.explain_statement
function that the dd agent expects to exist. I can setup everything in terraform except for the required function.https://docs.datadoghq.com/database_monitoring/setup_postgres/aurora/?tab=postgres10