Skip to content

Add go mod vendor to linter, user correct version of go #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

Jell
Copy link
Contributor

@Jell Jell commented Oct 8, 2021

The go lint action was broken after removing the vendor folder, this solves this.

I suspect it only worked on the last run in main due to the cache from a previous run that preserved the vendor folder.

@Jell Jell mentioned this pull request Oct 8, 2021
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've tested in a container and indeed, without go build or vendor before it doesn't work.

@Jell
Copy link
Contributor Author

Jell commented Jan 31, 2022

great! will you merge this PR @cyrilgdn? and I'll work on rebasing #134 on top of it

@Jell Jell force-pushed the fix_github_workflow branch from f4b39d0 to f32a92f Compare January 31, 2022 08:49
@cyrilgdn
Copy link
Owner

Yes sorry, I waited for the tests to be green but didn't triggered them yesterday 🤦‍♂️

@cyrilgdn cyrilgdn merged commit 850f928 into cyrilgdn:master Jan 31, 2022
SpencerBinXia pushed a commit to SpencerBinXia/terraform-provider-postgresql that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants