Skip to content

Update v9 examples to cypress 9.7.0 #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR resolves issue #685 "v9 examples do not use latest 9.x version 9.7.0".

Each of the test directories in examples/v9 is upgraded to use Cypress 9.7.0 (released May 23, 2022).

Cypress 9.7.0 is the latest Cypress 9.x version and the latest Cypress version which still uses Legacy configuration.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 11, 2023 18:46
Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm curious thought why some got a ^9.7.0 and some 9.7.0?

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

Looks good. I'm curious thought why some got a ^9.7.0 and some 9.7.0?

For npm-based examples I installed with npm install cypress@9 -D which resulted in ^9.7.0

yarn and pnpm were a bit trickier and their CLI command options are different so that is why they use 9.7.0 without the ^.

Thanks for cross-checking! I did most of the work for this about three weeks ago, and I have half forgotten the details! I will go back and double check.

@MikeMcC399 MikeMcC399 marked this pull request as draft January 11, 2023 20:35
@MikeMcC399
Copy link
Collaborator Author

Thank you for your valid question about ^9.7.0! I have revisited this.

Currently "cypress": "9.6.1", in each of the examples/v9 sub-directories, does not use npm's default semver range operator. To avoid changing that aspect I have re-done the update process for the npm-based examples using

npm install cypress@9 --save-dev --save-exact

(see https://docs.npmjs.com/cli/v8/commands/npm-install)

So now the Cypress version is uniformly selected with "cypress": "9.7.0", equivalent to how it was done previously.

The tests all pass and from my point of view this PR is ready to be merged.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 12, 2023 10:06
Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thx!!

@jaffrepaul jaffrepaul merged commit 7ebb7b1 into cypress-io:master Jan 13, 2023
@MikeMcC399 MikeMcC399 deleted the update/v9-examples branch January 13, 2023 05:18
@github-actions
Copy link

🎉 This PR is included in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants