-
Notifications
You must be signed in to change notification settings - Fork 364
Update v9 examples to cypress 9.7.0 #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm curious thought why some got a ^9.7.0
and some 9.7.0
?
For npm-based examples I installed with yarn and pnpm were a bit trickier and their CLI command options are different so that is why they use Thanks for cross-checking! I did most of the work for this about three weeks ago, and I have half forgotten the details! I will go back and double check. |
8da11e3
to
f1757a1
Compare
Thank you for your valid question about Currently
(see https://docs.npmjs.com/cli/v8/commands/npm-install) So now the Cypress version is uniformly selected with The tests all pass and from my point of view this PR is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thx!!
🎉 This PR is included in version 5.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR resolves issue #685 "v9 examples do not use latest 9.x version 9.7.0".
Each of the test directories in examples/v9 is upgraded to use Cypress 9.7.0 (released May 23, 2022).
Cypress 9.7.0 is the latest Cypress 9.x version and the latest Cypress version which still uses Legacy configuration.