-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: fix pre-release download for win32-arm64 #31836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix pre-release download for win32-arm64 #31836
Conversation
follow-on fix for PR cypress-io#31784
|
Since it's not possible to test this before merging, I did at least test a manual patch in https://github.com/MikeMcC399/cypress-example-kitchensink/tree/use/windows-11-arm-beta-patched with the successful result in https://github.com/MikeMcC399/cypress-example-kitchensink/actions/runs/15472230351 Logs
|
@MikeMcC399 Yah, we're aware that it's not that testable ahead of time, but figure the worst that can happen is that it still doesn't work. :/ |
Thanks for your optimism! The worst that can happen here is that the PR screws up downloading all pre-release software. Plan B would be to revert it, if it causes a catastrophic failure. (I'm not really expecting that to be necessary!) At the moment I've been seeing also corrupt download messages for the pre-release package. It seems to be sporadic:
Same for the latest pre-release based on 76eb083. The first time I tried it, I got a checksum error and the second time it worked. Don't quite know what's going on there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeMcC399 is it possible to add a unit test for this here?
This comment was marked as resolved.
This comment was marked as resolved.
Unit test is added and is passing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought I approved this beforehand before hitting the merge button. Either way everything looked good and approved on my end
Successfully tested with npm install https://cdn.cypress.io/beta/npm/14.5.0/win32-x64/develop-4450d3be74d72f61169a117bbc0bffef8d1d58fa/cypress.tgz in https://github.com/MikeMcC399/cypress-example-kitchensink/tree/use/windows-11-arm-beta with environment:
and workflow log on: Logs
|
Additional details
Attempting to install the Cypress binary from the pre-release npm package
https://cdn.cypress.io/beta/npm/14.5.0/win32-x64/develop-ec252f8601d9cec4543085667c7e03ecdab8e82f/cypress.tgz
on the GitHub runner
windows-11-arm
fails with
Cypress does not build for
win32-arm64
and so there is no such binary available.This PR changes the URL selection for pre-releases of Cypress running on
win32-arm64
to download the correspondingwin32-x64
Cypress binary instead.Steps to test
After this PR is merged, install the generated pre-release package into:
https://github.com/MikeMcC399/cypress-example-kitchensink/tree/use/windows-11-arm-beta
Review the results of workflow:
https://github.com/MikeMcC399/cypress-example-kitchensink/actions/workflows/chrome.yml
How has the user experience changed?
Users will be able to follow the Cypress documentation instructions Install pre-release version successfully also on Windows Arm-based PCs.
PR Tasks
cypress-documentation
? covered by Add Windows 11 24H2 arm64 support cypress-documentation#6193type definitions
?cc: @AtofStryker