Skip to content

chore: add node 24 base image to binary system tests #31661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented May 7, 2025

Additional details

Adds Node 24, which released May 6th, 2025, to Cypress' binary system tests

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented May 7, 2025

cypress    Run #62248

Run Properties:  status check passed Passed #62248  •  git commit 787b4c42c8: chore: add node 24 base image to binary system tests
Project cypress
Branch Review chore/add_node_24_tests
Run status status check passed Passed #62248
Run duration 18m 46s
Commit git commit 787b4c42c8: chore: add node 24 base image to binary system tests
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 1232
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32157
View all changes introduced in this branch ↗︎
UI Coverage  46.24%
  Untested elements 188  
  Tested elements 166  
Accessibility  92.74%
  Failed rules  3 critical   9 serious   2 moderate   2 minor
  Failed elements 888  

@AtofStryker AtofStryker self-assigned this May 7, 2025
@AtofStryker AtofStryker merged commit ee028ea into develop May 7, 2025
92 of 94 checks passed
@AtofStryker AtofStryker deleted the chore/add_node_24_tests branch May 7, 2025 19:39
@MikeMcC399
Copy link
Contributor

At some stage before the Cypress 15 release, ^24.0.0 would need to be added here:

"node": "^20.0.0 || ^22.0.0"

@AtofStryker
Copy link
Contributor Author

At some stage before the Cypress 15 release, ^24.0.0 would need to be added here:

"node": "^20.0.0 || ^22.0.0"

@MikeMcC399 I'm taking care of it in #31662. It's in the merge commit so it's a bit masked but it will be added to the 15 branch shortly!

@MikeMcC399
Copy link
Contributor

@AtofStryker

I'm taking care of it in #31662. It's in the merge commit so it's a bit masked but it will be added to the 15 branch shortly!

Ah yes, I thought I had seen it somewhere in passing, but then I couldn't find it! Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Cypress compatibility with Node.js 24
3 participants