-
Notifications
You must be signed in to change notification settings - Fork 3.3k
misc: Remove migration UI, warnings, and errors for changes pre-Cypress 10 (v15) #31629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… remove-migration
…emove-migration
… remove-migration
…emove-migration
… remove-migration
…emove-migration
binaries to test are here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes legacy migration UI, warnings, and errors for pre‑Cypress 10 configurations while also cleaning up related code and tests. Key changes include:
- Deleting the entire MigrationDataSource and LegacyPluginsIpc modules.
- Removing migration-related logic from data sources, actions, and the project lifecycle manager.
- Updating tests, snapshots, docs, and CI configurations to reflect these removals.
Reviewed Changes
Copilot reviewed 457 out of 457 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/data-context/src/sources/MigrationDataSource.ts | Removed legacy migration data source and related migration functions. |
packages/data-context/src/data/index.ts | Removed export for LegacyPluginsIpc to clean up unused code. |
packages/data-context/src/data/coreDataShape.ts | Cleaned out migration interfaces and state from core data structure. |
packages/data-context/src/data/ProjectLifecycleManager.ts | Removed legacy migration checks and methods; adjusted conditions for configuration processing. |
packages/data-context/src/codegen/spec-options.ts | Updated import path to use the new util folder instead of migration utilities. |
packages/data-context/src/actions/* | Removed migration actions from both index and ProjectActions modules. |
packages/config/* | Updated tests, config options, and snapshots to remove references to deprecated migration options and legacy warnings. |
npm/grep/README.md, guides/error-handling.md | Updated documentation to refer to the new config file format and error messages. |
.circleci/workflows.yml | Updated branch filters to reflect the removal of migration-related branches. |
Comments suppressed due to low confidence (5)
packages/data-context/src/sources/MigrationDataSource.ts:1
- Ensure that all references and imports of MigrationDataSource are removed from the codebase so that no broken dependencies remain.
/* Entire file removed */
.circleci/workflows.yml:41
- The branch filter was updated to 'remove-migration'; please ensure that this change is coordinated with all related CI configurations to avoid unintended build exclusions.
- - 'remove-migration'
packages/data-context/src/data/ProjectLifecycleManager.ts:761
- [nitpick] The removal of the migration check in the e2e condition simplifies the logic; please confirm that this change is intended and that no legacy behavior is required for e2e projects.
if (testingType === 'e2e') {
guides/error-handling.md:81
- [nitpick] The error message now references 'fakeFile' instead of 'pluginsFile'. Confirm that this change in terminology is intentional and that the documentation reflects the new naming convention.
FAKE_ERROR: (arg1: string, arg2: Error) => {
packages/data-context/src/codegen/spec-options.ts:6
- Verify that updating the import path for getDefaultSpecFileName aligns with the current project structure and that there are no residual dependencies on the old migration utilities path.
import { FileExtension, getDefaultSpecFileName } from '../util/files'
@@ -830,7 +830,8 @@ describe('lib/cypress', () => { | |||
] | |||
|
|||
renamedConfigs.forEach(function (config) { | |||
it(`logs error and exits when using an old configuration option: ${config.old}`, function () { | |||
// TODO: remove this skip once we have a renamed config option - there are none active now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I understand the skip here? We should probably create a git issue and explain this in more detail and link it back here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we don't have any renamed config option errors that are active. So, we haven't renamed any configurations since 10.x (where there would be a key of newName
in the breakingOptions
), so I don't have a real use case to test here. There's already a unit test for this behavior, this was checking integration.
Co-authored-by: Bill Glesias <[email protected]>
Co-authored-by: Bill Glesias <[email protected]>
Additional details
🎉 13,000+ lines of code removed! 🎉
cypress.json
files will not be suggested to migrate.blacklistHosts
componentFolder
experimentalComponentTesting
experimentalGetCookiesSameSite
experimentalNetworkStubbing
experimentalRunEvents
experimentalSessionSupport
experimentalShadowDomSupport
firefoxGcInterval
ignoreTestFiles
integrationFolder
pluginsFile
testFiles
cypress-plugin-retries
package will no longer receive an error to switch to 'retries' configuration.matchUrlAgainstPath
tocy.intercept()
will no longer receive an error (removed in 7.0)--canary
will no longer see an error (removed in 4.0)dev-server:start
listeners will no longer receive an error (removed in 10.0)Steps to test
How has the user experience changed?
Migration helpers and related errors are no longer shown when upgrading from Cypress versions earlier than 10.0.0.
PR Tasks
cypress-documentation
?type definitions
?