-
Notifications
You must be signed in to change notification settings - Fork 3.3k
misc: update some of the dark gray UI to be darker gray for better co… #31475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cypress
|
Project |
cypress
|
Branch Review |
update-gray-1100
|
Run status |
|
Run duration | 16m 23s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
4
|
|
145
|
|
0
|
|
6404
|
View all changes introduced in this branch ↗︎ |
UI Coverage
43.85%
|
|
---|---|
|
73
|
|
57
|
Accessibility
94.94%
|
|
---|---|
|
0 critical
6 serious
0 moderate
1 minor
|
|
130
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ. Any idea why percy didn't pick up the changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably minor enough where it's hard for Percy to detect?
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This updates the background of the reporter areas to the correct background color from Figma.
This background color was introduced to create more contrast for better accessibility
Steps to test
packages/app
, runyarn cypress:open
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation
?type definitions
?