Skip to content

misc: update some of the dark gray UI to be darker gray for better co… #31475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Apr 9, 2025

Additional details

This updates the background of the reporter areas to the correct background color from Figma.

  • URL bar bg
  • Reporter bg
    • Commands bg
    • Errors stack bg
    • loading tests bg
  • Selector playground bg

This background color was introduced to create more contrast for better accessibility

Steps to test

  • Within packages/app, run yarn cypress:open

How has the user experience changed?

Before

Screenshot 2025-04-10 at 8 52 38 AM

After

Screenshot 2025-04-10 at 8 56 51 AM

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Apr 9, 2025
Copy link

cypress bot commented Apr 9, 2025

cypress    Run #61514

Run Properties:  status check passed Passed #61514  •  git commit dd68c644ed: update reporter section variable color
Project cypress
Branch Review update-gray-1100
Run status status check passed Passed #61514
Run duration 16m 23s
Commit git commit dd68c644ed: update reporter section variable color
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 145
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 6404
View all changes introduced in this branch ↗︎
UI Coverage  43.85%
  Untested elements 73  
  Tested elements 57  
Accessibility  94.94%
  Failed rules  0 critical   6 serious   0 moderate   1 minor
  Failed elements 130  

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ. Any idea why percy didn't pick up the changes?

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably minor enough where it's hard for Percy to detect?

@jennifer-shehane jennifer-shehane merged commit 705580f into develop Apr 10, 2025
93 of 94 checks passed
@jennifer-shehane jennifer-shehane deleted the update-gray-1100 branch April 10, 2025 16:46
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 17, 2025

Released in 14.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants