Skip to content

chore: fix contributor workflow for @packages/app flow component testing #31458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AtofStrykerContributor
Copy link
Contributor

@AtofStrykerContributor AtofStrykerContributor commented Apr 7, 2025

Additional details

This PR fixes an issue with contributor app component tests were tests were being skipped due to unknown flake. It looks like the flake is related in two areas:

  • vite re optimizing dependencies and triggering a reload of the AUT while specs are running, which causes failures until the AUT is reloaded
  • cypress-real-events mutating some not cleared out state that has a impact on the selector playground

Steps to test

run the app component tests as a contributor and see that they are now passing. You can also run these locally with the same spec params and they should pass on this branch and fail in develop.

This doesn't seem to fail nearly as much for workspace people as we record , which is likely due to the order of the sepcs run via spec prioritization

How has the user experience changed?

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@AtofStryker AtofStryker self-requested a review April 7, 2025 16:39
@AtofStrykerContributor AtofStrykerContributor changed the title Test contributor flow component testing chore fix contributor workflow for @packages/app flow component testing Apr 7, 2025
@AtofStrykerContributor AtofStrykerContributor changed the title chore fix contributor workflow for @packages/app flow component testing chore: fix contributor workflow for @packages/app flow component testing Apr 7, 2025
@AtofStryker AtofStryker self-assigned this Apr 8, 2025
@AtofStryker AtofStryker requested review from jennifer-shehane and removed request for AtofStryker April 8, 2025 16:48
@jennifer-shehane jennifer-shehane merged commit 696ba74 into cypress-io:develop Apr 8, 2025
73 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 8, 2025

Released in 14.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributor PRs not running component UI tests
5 participants