-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore(deps): update patch-package to snap-shot-core 10.2.4 #31441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update patch-package to snap-shot-core 10.2.4 #31441
Conversation
|
Patch is now successfully applied. |
@MikeMcC399 I'm wondering if we should parse the output in the npm install to look for ''Warning: patch-package detected a patch file version mismatch. We keep running into these issues with patch-package failures not being very obvious. Gonna discuss with the team. Or maybe fail on warnings... |
I only noticed this when I was running CI should probably fail on "Warning: patch-package detected a patch file version mismatch" which would enable the problem to be identified and fixed together with the PR that triggered the version mismatch before it got merged. |
I think something is broken in contributor PRs here. |
Maybe something around this line
|
The changes in this PR should not affect anything apart from the warning from patch-package. Would you like to submit this change yourself and close this PR or do you think you can solve the CI issue? It would probably be good to get the patch warning fixed before the next release, but that would be your call. |
@MikeMcC399 Yah, I'll open a new PR. Someone is going to look into the contributor issue today. |
Opened here: #31449 |
Issue for contributor PR problem: #31450 |
Additional details
Issue background
yarn
a warning "Warning: patch-package detected a patch file version mismatch" appearsChanges made
Renamed
to
Steps to test
git clone https://github.com/cypress-io/cypress cd cypress yarn
Confirm no warnings when patches are applied:
How has the user experience changed?
This change removes a warning for contributors. There should be no change for end-users of Cypress.
PR Tasks
cypress-documentation
?type definitions
?