Skip to content

chore(deps): update patch-package to snap-shot-core 10.2.4 #31441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MikeMcC399
Copy link
Contributor

Additional details

Issue background

Changes made

Renamed

to

Steps to test

git clone https://github.com/cypress-io/cypress
cd cypress
yarn

Confirm no warnings when patches are applied:

How has the user experience changed?

This change removes a warning for contributors. There should be no change for end-users of Cypress.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane
Copy link
Member

@MikeMcC399 I'm wondering if we should parse the output in the npm install to look for ''Warning: patch-package detected a patch file version mismatch. We keep running into these issues with patch-package failures not being very obvious. Gonna discuss with the team. Or maybe fail on warnings...

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

I'm wondering if we should parse the output in the npm install to look for ''Warning: patch-package detected a patch file version mismatch. We keep running into these issues with patch-package failures not being very obvious. Gonna discuss with the team. Or maybe fail on warnings...

I only noticed this when I was running yarn locally.

CI should probably fail on "Warning: patch-package detected a patch file version mismatch" which would enable the problem to be identified and fixed together with the PR that triggered the version mismatch before it got merged.

@jennifer-shehane
Copy link
Member

I think something is broken in contributor PRs here.

@jennifer-shehane
Copy link
Member

Maybe something around this line

TESTFILES=$(find src -regextype posix-extended -name '*.cy.*' -not -regex '.*(FileMatch|PromoAction|SelectorPlayground|useDurationFormat|useTestingType|SpecPatterns).cy.*' | circleci tests split --total=$CIRCLE_NODE_TOTAL)

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

I think something is broken in contributor PRs here.

The changes in this PR should not affect anything apart from the warning from patch-package.

Would you like to submit this change yourself and close this PR or do you think you can solve the CI issue?

It would probably be good to get the patch warning fixed before the next release, but that would be your call.

@jennifer-shehane
Copy link
Member

@MikeMcC399 Yah, I'll open a new PR. Someone is going to look into the contributor issue today.

@jennifer-shehane
Copy link
Member

Opened here: #31449

@jennifer-shehane
Copy link
Member

Issue for contributor PR problem: #31450

@MikeMcC399 MikeMcC399 deleted the issue-31440-snap-shot-core-patch branch April 8, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

patch-package warning for snap-shot-core
3 participants