breaking: remove CDP from firefox with Cypress 15 #31200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
b9fbe9b to
dff3dbf
Compare
AtofStryker
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_cdp_firefox
|
| Run status |
|
| Run duration | 11m 11s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
672
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
37.81%
|
|
|---|---|
|
Untested elements
|
125
|
|
Tested elements
|
76
|
Accessibility
92.17%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
1 moderate
1 minor
|
|
Failed elements
|
516
|
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
dff3dbf to
07c5a8e
Compare
AtofStryker
changed the title
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
07c5a8e to
52676da
Compare
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
52676da to
70e438d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes all support for the Chrome DevTools Protocol (CDP) from Firefox in favor of WebDriver BiDi as part of Cypress 15. The major changes include the removal of CDP-specific tests and code paths, updates to Firefox version validations, and cleanup of associated configuration and error messages.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/test/cdp_deprecated_firefox_spec.ts | Removed tests specifically for deprecation warnings related to CDP in Firefox. |
| packages/server/lib/* | Eliminated CDP-related functionality and error handling in favor of BiDi. |
| packages/launcher/* | Updated Firefox version requirements and validators to require version ≥135. |
| packages/extension/* | Removed CDP escape hatch logic and associated header listeners. |
| cli/CHANGELOG.md | Updated changelog with breaking changes; now references removal of CDP support. |
| .circleci/workflows.yml | Removed jobs and configuration options related to running Firefox with CDP. |
Files not reviewed (1)
- packages/graphql/schemas/schema.graphql: Language not supported
Comments suppressed due to low confidence (1)
cli/CHANGELOG.md:8
- Consider updating or removing the placeholder 'Addresses ' link to provide clear reference information for users regarding this breaking change.
**Breaking Changes:** - Removed support for [Chrome DevTools Protocol](https://chromedevtools.github.io/devtools-protocol) with the [firefox](https://www.mozilla.org/) browser. Addresses []().
mschile
reviewed
Apr 1, 2025
mschile
reviewed
Apr 1, 2025
| // To enable BiDi (without CDP), we need to set | ||
| // remote.active-protocol=1 | ||
| // In order to enable CDP (without BiDi), we need to set | ||
| // In order to enable CDP (without BiDi on firefox older than version 135), we need to set |
There was a problem hiding this comment.
Should this comment just be updated to remove active-protocol 2 and 3 since we don't support them anymore?
There was a problem hiding this comment.
I wanted to keep some type of historical reference as to how to turn on CDP if needed. I think this comment needs some word smithing.
There was a problem hiding this comment.
tried to wordsmith this better in 425bbaa
mschile
reviewed
Apr 1, 2025
cli/CHANGELOG.md
Outdated
|
|
||
| **Breaking Changes:** | ||
|
|
||
| - Removed support for [Chrome DevTools Protocol](https://chromedevtools.github.io/devtools-protocol) with the [firefox](https://www.mozilla.org/) browser. Addresses [](). |
There was a problem hiding this comment.
Add a link to which issue addresses.
There was a problem hiding this comment.
added in 425bbaa
mschile
approved these changes
Apr 1, 2025
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
ee30eb9 to
425bbaa
Compare
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
425bbaa to
c7f8493
Compare
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
c7f8493 to
e3bac5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
CDP will be removed with Firefox 141 see blogpost. Following Cypress last 3 major versions supported and relasing Cypress 15, it makes sense to remove CDP support within Firefox.
Since this could be a disruptive change to users using older versions of Firefox, we feel this is best to put this into a major version change, though it isn't technically a breaking change to the Cypress API
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation? chore: remove CDP deprecation notice cypress-documentation#6116type definitions?