Skip to content

chore: temporarily patch windows build to install dependencies as caching is currently broken #30350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 3, 2024

  • Closes N/A

Additional details

See #30343 for more details. This is a temporary workaround to get the windows builds passing so we can build the binary and release the binary. This is not efficient as we have to reinstall dependencies each job, but it does work in the meantime

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker changed the title chore: temporarily patch windows build to install depdencies as cachi… chore: temporarily patch windows build to install dependencies as caching is currently broken Oct 3, 2024
@AtofStryker AtofStryker self-assigned this Oct 3, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow and the tests passed. 😅

@jennifer-shehane jennifer-shehane merged commit 02be8e5 into develop Oct 3, 2024
97 of 99 checks passed
@jennifer-shehane jennifer-shehane deleted the chore/patch_windows_build branch October 3, 2024 13:36
AtofStryker added a commit that referenced this pull request Oct 11, 2024
…s as caching is currently broken (#30350)"

This reverts commit 02be8e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants